Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use order_desc shared control consistently #19172

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

Currently we have order_desc shared control. Here we reuse it for any charts which use this control.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #19172 (528e5c9) into master (b5e9fad) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #19172      +/-   ##
==========================================
+ Coverage   66.76%   66.77%   +0.01%     
==========================================
  Files        1670     1670              
  Lines       64398    64384      -14     
  Branches     6499     6500       +1     
==========================================
  Hits        42993    42993              
+ Misses      19722    19707      -15     
- Partials     1683     1684       +1     
Flag Coverage Δ
javascript 51.33% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ns/legacy-plugin-chart-horizon/src/controlPanel.ts 100.00% <ø> (+50.00%) ⬆️
...acy-plugin-chart-paired-t-test/src/controlPanel.ts 100.00% <ø> (+50.00%) ⬆️
...gin-chart-parallel-coordinates/src/controlPanel.ts 100.00% <ø> (+50.00%) ⬆️
...legacy-plugin-chart-partition/src/controlPanel.tsx 33.33% <ø> (+8.33%) ⬆️
...egacy-plugin-chart-pivot-table/src/controlPanel.ts 100.00% <ø> (+50.00%) ⬆️
...gins/legacy-plugin-chart-rose/src/controlPanel.tsx 100.00% <ø> (+50.00%) ⬆️
...ns/legacy-plugin-chart-treemap/src/controlPanel.ts 100.00% <ø> (+50.00%) ⬆️
...gacy-preset-chart-nvd3/src/DistBar/controlPanel.ts 11.11% <ø> (+1.11%) ⬆️
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 40.00% <ø> (+6.66%) ⬆️
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 40.00% <ø> (+6.66%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e9fad...528e5c9. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review March 18, 2022 11:05
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 10eb6c7 into apache:master Mar 18, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/L 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants