-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Logic for showing extension in Global Nav #19158
Conversation
9e8ee9d
to
6a2b239
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #19158 +/- ##
==========================================
- Coverage 66.55% 66.40% -0.16%
==========================================
Files 1646 1646
Lines 63632 63632
Branches 6476 6476
==========================================
- Hits 42353 42252 -101
- Misses 19597 19698 +101
Partials 1682 1682
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6a2b239
to
9723ef0
Compare
perm: Array<any> | string | undefined | boolean, | ||
cons: Array<any>, | ||
) => { | ||
export const checkUploadExtensions = (perm: Array<any>, cons: Array<any>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, but I think an array of strings is the only type that would make sense, if you want to be more specific.
🏷️ preset:2022.11 |
* fix logic for checking extensions * add specific types * fix lint (cherry picked from commit 181ecf4)
* fix logic for checking extensions * add specific types * fix lint (cherry picked from commit 181ecf4)
SUMMARY
Before we had back logic for showing the allowed extensions in the global nav, we've moved it by simplifying where the logic lives in the dropdown nav
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION