perf(dashboard): Send chart requests before native filter requests

[kgabryje]

SUMMARY

For performance reasons, when a dashboard loads, native filters requests are delayed until chart requests were triggered. However, that's not the case when user clicks "Refresh dashboard" button. This PR fixes that issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

In the Network panel on the right you can see the requests sent after clicking "Refresh dashboard". The ones that just say data are native filter requests. The other ones are chart requests. The goal was to make sure that all native filter requests were made after chart requests

Before:

After:

TESTING INSTRUCTIONS

1. Create a dashboard with multiple charts and native filters
2. Open Chrome dev tools network tab
3. Click "Refresh dashboard"
4. Make sure that all native filter requests were made after chart requests

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

https://app.shortcut.com/preset/story/38199/refresh-dashboard-performance-issue-filter-requests-blocking-chart-requests

[codecov]

Codecov Report

Merging #19077 (4431e62) into master (79a7a5d) will increase coverage by 0.00%.
The diff coverage is 38.46%.

@@           Coverage Diff           @@
##           master   #19077   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1643     1643           
  Lines       63462    63474   +12     
  Branches     6449     6451    +2     
=======================================
+ Hits        42210    42218    +8     
- Misses      19582    19586    +4     
  Partials     1670     1670           

Flag	Coverage Δ
javascript	51.24% <38.46%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js	2.08% <ø> (ø)
...-frontend/src/dashboard/reducers/dashboardState.js	73.33% <0.00%> (-3.42%)	⬇️
...t-frontend/src/dashboard/actions/dashboardState.js	36.06% <28.57%> (+0.11%)	⬆️
...veFilters/FilterBar/FilterControls/FilterValue.tsx	60.43% <47.05%> (+3.46%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a7a5d...4431e62. Read the comment docs.

[geido]

/testenv up

[github-actions]

@geido Ephemeral environment spinning up at http://54.188.132.226:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[geido]

LGTM!

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.