fix: Show Totals error with sort and group by together

[codemaster08240328]

SUMMARY

Before this update, creating a chart with show total flag on, group by and sort by, we used to get error response from the server, because as you can see from the below screenshot, the second query was invalid.

So, I removed sort by and desc from the extra query (which is being created when we flag show total on).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19072 (6687141) into master (c75f233) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19072   +/-   ##
=======================================
  Coverage   66.50%   66.50%           
=======================================
  Files        1642     1642           
  Lines       63442    63442           
  Branches     6439     6439           
=======================================
+ Hits        42189    42191    +2     
+ Misses      19583    19582    -1     
+ Partials     1670     1669    -1     

Flag	Coverage Δ
javascript	51.22% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ntend/plugins/plugin-chart-table/src/buildQuery.ts	55.93% <ø> (ø)
superset-frontend/src/views/components/Menu.tsx	58.97% <0.00%> (+2.56%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75f233...6687141. Read the comment docs.

[rusackas]

/testenv up

[github-actions]

@rusackas Ephemeral environment spinning up at http://35.89.28.169:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[rusackas]

The first two screenshots are super low resolution for some reason.

It'd also be helpful to put the repro steps in the Testing section of the PR description:

Repro steps

1. Create a table chart with public.flights dataset
   • Group-by: Destination Airport
   • Metrics: SUM(Air_Time)
   • Sort-by: Destination Airport (input as custom SQL with no
     summation to actually sort by the letters)
   • Select ‘Show Totals’ - Hit Run
2. Error is shown (without Sort-by being populated, it runs correctly)

[rusackas]

Works well in testing! LGTM!

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.