feat: scroll to bottom when adding a new native filter and the page is filled #19053

diegomedina248 · 2022-03-08T00:58:59Z

SUMMARY

When adding a native filter, and the page is already filled (with other filters), auto-scroll to the bottom so that the newly added filter is visible on the left panel.

Also, fixes a typo in the onRearrange function.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-03-07.at.21.56.31.mov

After:

Screen.Recording.2022-03-07.at.21.50.20.mov

TESTING INSTRUCTIONS

Go to any dashboard
Hit the Add/Edit filters button on the left panel
Start adding filters & dividers
Ensure that, when the filter container fills the screen, adding new filters scrolls the container to the bottom

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…s filled

yousoph · 2022-03-08T05:28:55Z

/testenv up

github-actions · 2022-03-08T05:29:29Z

@yousoph Container image not yet published for this PR. Please try again when build is complete.

github-actions · 2022-03-08T05:29:30Z

@yousoph Ephemeral environment creation failed. Please check the Actions logs for details.

rusackas · 2022-03-09T00:15:40Z

Unit tests have failed on this one a couple times despite re-running CI... could you check to see if they're passing locally?

…scroll-to-bottom-when-adding-native-filters

codecov · 2022-03-09T16:32:28Z

Codecov Report

Merging #19053 (2b1922a) into master (f9c7405) will increase coverage by 0.00%.
The diff coverage is 55.31%.

@@           Coverage Diff           @@
##           master   #19053   +/-   ##
=======================================
  Coverage   66.50%   66.50%           
=======================================
  Files        1642     1643    +1     
  Lines       63442    63460   +18     
  Branches     6439     6449   +10     
=======================================
+ Hits        42191    42205   +14     
- Misses      19582    19585    +3     
- Partials     1669     1670    +1

Flag	Coverage Δ
javascript	`51.24% <55.31%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ilters/FiltersConfigModal/FilterTitleContainer.tsx	`57.14% <48.78%> (ø)`
...tiveFilters/FiltersConfigModal/DraggableFilter.tsx	`71.87% <100.00%> (ø)`
...Filters/FiltersConfigModal/FilterConfigurePane.tsx	`100.00% <100.00%> (ø)`
...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx	`83.33% <100.00%> (+2.08%)`	⬆️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	`64.67% <100.00%> (ø)`
...frontend/src/SqlLab/components/SqlEditor/index.jsx	`50.84% <0.00%> (-0.60%)`	⬇️
superset-frontend/src/views/CRUD/hooks.ts	`47.15% <0.00%> (ø)`
...perset-frontend/src/addSlice/AddSliceContainer.tsx	`61.76% <0.00%> (ø)`
...rontend/src/visualizations/TimeTable/TimeTable.jsx	`0.00% <0.00%> (ø)`
superset-frontend/src/utils/sortNumericValues.ts	`100.00% <0.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c7405...2b1922a. Read the comment docs.

rusackas · 2022-03-09T19:29:28Z

...frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx

@@ -65,7 +72,7 @@ test('renders form', async () => {

 test('drag and drop', async () => {
  defaultRender();
-  // Drag the state and contry filter above the product filter
+  // Drag the state and country filter above the product filter


Thanks for cleaning up all the typos and things along the way. You're making the world a better place! 🧹 ✨

rusackas · 2022-03-09T19:32:18Z

/testenv up

github-actions · 2022-03-09T19:34:11Z

@rusackas Ephemeral environment spinning up at http://34.220.228.251:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas

LGTM, and works well in testing. Just re-triggered E2E tests 🤞 . CC @kgabryje and @michael-s-molina in case you spot any risks I didn't.

kgabryje

LGTM

github-actions · 2022-03-17T03:19:17Z

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe · 2022-03-18T19:14:12Z

🏷️ preset:2022.11

…s filled (apache#19053) * feat: Scroll to bottom when adding a new native filter and the page is filled * Add test (cherry picked from commit cfb967f)

…s filled (#19053) * feat: Scroll to bottom when adding a new native filter and the page is filled * Add test (cherry picked from commit cfb967f)

feat: Scroll to bottom when adding a new native filter and the page i…

ed13533

…s filled

pull-request-size bot added the size/L label Mar 8, 2022

diegomedina248 added 2 commits March 9, 2022 11:11

Merge branch 'master' of github.com:diegomedina248/superset into fix/…

e90f8fd

…scroll-to-bottom-when-adding-native-filters

Add test

2b1922a

rusackas reviewed Mar 9, 2022

View reviewed changes

rusackas approved these changes Mar 16, 2022

View reviewed changes

michael-s-molina approved these changes Mar 16, 2022

View reviewed changes

kgabryje approved these changes Mar 16, 2022

View reviewed changes

rusackas merged commit cfb967f into apache:master Mar 17, 2022

superset-github-bot bot added the preset:2022.11 label Mar 18, 2022

villebro added the lts-v1 label Mar 29, 2022

mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: scroll to bottom when adding a new native filter and the page is filled #19053

feat: scroll to bottom when adding a new native filter and the page is filled #19053

diegomedina248 commented Mar 8, 2022 •

edited by michael-s-molina

Loading

yousoph commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

rusackas commented Mar 9, 2022

codecov bot commented Mar 9, 2022

rusackas Mar 9, 2022

rusackas commented Mar 9, 2022

github-actions bot commented Mar 9, 2022

rusackas left a comment

kgabryje left a comment

github-actions bot commented Mar 17, 2022

sadpandajoe commented Mar 18, 2022

feat: scroll to bottom when adding a new native filter and the page is filled #19053

feat: scroll to bottom when adding a new native filter and the page is filled #19053

Conversation

diegomedina248 commented Mar 8, 2022 • edited by michael-s-molina Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

yousoph commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

github-actions bot commented Mar 8, 2022

rusackas commented Mar 9, 2022

codecov bot commented Mar 9, 2022

Codecov Report

rusackas Mar 9, 2022

Choose a reason for hiding this comment

rusackas commented Mar 9, 2022

github-actions bot commented Mar 9, 2022

rusackas left a comment

Choose a reason for hiding this comment

kgabryje left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 17, 2022

sadpandajoe commented Mar 18, 2022

diegomedina248 commented Mar 8, 2022 •

edited by michael-s-molina

Loading