fix(sqllab): Replace stringified 'null' schema column values with NULL #18992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Mar 1, 2022
| __tablename__ = "saved_query" | ||
|
|
||
| id = Column(Integer, primary_key=True) | ||
| schema = Column(String(128)) |
There was a problem hiding this comment.
It's not evident why these tables use different string sizes for encoding the schema.
etr2460
reviewed
Mar 1, 2022
| __tablename__ = "saved_query" | ||
|
|
||
| id = Column(Integer, primary_key=True) | ||
| schema = Column(String(128)) |
Codecov Report
@@ Coverage Diff @@
## master #18992 +/- ##
==========================================
- Coverage 66.58% 66.39% -0.20%
==========================================
Files 1641 1641
Lines 63524 63524
Branches 6421 6421
==========================================
- Hits 42299 42178 -121
- Misses 19548 19669 +121
Partials 1677 1677
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@etr2460 I've addressed your comment. |
etr2460
approved these changes
Mar 2, 2022
villebro
pushed a commit
that referenced
this pull request
Apr 3, 2022
#18992) Co-authored-by: John Bodley <[email protected]> (cherry picked from commit 19eb73b)
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I'm not sure exactly when this came about, though I believe the issue has been resolved recently (albeit not being able to identify the relevant PR(s)), but it seems at some stage we were stringifying an undefined (
NULL) schema in SQL Lab as"null"in both thequeryandsaved_querytables resulting in some undesirable user behavior.This PR includes a migration which simply replaces the
nullstring withNULL, i.e., undefined.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI and ran the upgrade/downgrade manually. Also ran the bench-marking script (thanks @betodealmeida) which produced the following results:
ADDITIONAL INFORMATION