Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Change Dataset legacy editor flag to true #18970

Merged
merged 1 commit into from
Mar 1, 2022
Merged

chore: Change Dataset legacy editor flag to true #18970

merged 1 commit into from
Mar 1, 2022

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Feb 28, 2022 •
edited by eschutho
Loading

SUMMARY

This set the disable legacy editor config to true, thus hiding the outdated legacy datasource editor.

This is a breaking change for Superset 2.0

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [2.0] Enable flag for disabling Legacy Datasource Editor. #18687
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@superset-github-bot superset-github-bot bot added the Superset-Community-Partners Preset community partner program participants label Feb 28, 2022
pkdotson
pkdotson approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AAfghahi AAfghahi merged commit 150fd0d into apache:master Mar 1, 2022
@eschutho eschutho added risk:breaking-change Issues or PRs that will introduce breaking changes v2.0 and removed Superset-Community-Partners Preset community partner program participants labels Mar 1, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkdotson pkdotson pkdotson approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/XS 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AAfghahi @pkdotson @mistercrunch @eschutho @michael-s-molina