-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(native filter): add new native filter test for time column filter #18850
test(native filter): add new native filter test for time column filter #18850
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18850 +/- ##
=======================================
Coverage 66.21% 66.21%
=======================================
Files 1633 1633
Lines 63210 63210
Branches 6409 6409
=======================================
Hits 41852 41852
Misses 19698 19698
Partials 1660 1660
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
61ac29c
to
c55112f
Compare
@jinghua-qa The size of this file is getting quite big and a lot of functionality is being repeated between the tests. I think it's time to refactor this code and extract the common behaviors to functions so it's easier to read. |
That is a very good suggestion~ I will plan for this refactor project and do it in another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the observation to refactor this code in a follow-up PR.
add new native filter test : User can create a time column filter
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION