fix: update standalone url for slack reports #18756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18756 +/- ##
=======================================
Coverage 66.31% 66.31%
=======================================
Files 1620 1620
Lines 63080 63082 +2
Branches 6370 6370
=======================================
+ Hits 41833 41835 +2
Misses 19591 19591
Partials 1656 1656
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
requested review from
betodealmeida,
eschutho,
lyndsiWilliams and
pkdotson
|
Looks great! Thanks for jumping on this. Can you also write a test for it? I think you could maybe repurpose @AAfghahi's. |
Just updated slack test that give us access to the url |
eschutho
approved these changes
Feb 17, 2022
hughhhh
force-pushed
the
update-slack-report
branch
from
2507822 to
903aa4e
Compare
|
🏷 preset:2022.7 |
rosemarie-chiu
pushed a commit
to preset-io/superset
that referenced
this pull request
Feb 18, 2022
* update url for slack reports * fix test * update text to be dynamic (cherry picked from commit 5d2e726)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following #18157 we forgot to update the slack url with the new modify url function
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION