-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updating link to newer viz plugin blog post #18707
chore: updating link to newer viz plugin blog post #18707
Conversation
@villebro I just noticed this link... but it might be worth a look to see if there are more things worth updating in |
Codecov Report
@@ Coverage Diff @@
## master #18707 +/- ##
==========================================
- Coverage 66.28% 66.25% -0.03%
==========================================
Files 1605 1605
Lines 62863 62863
Branches 6341 6341
==========================================
- Hits 41666 41650 -16
- Misses 19545 19561 +16
Partials 1652 1652
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
CONTRIBUTING.md
Outdated
[So, You Want to Build a Superset Viz Plugin...](https://preset.io/blog/2020-07-02-hello-world/) blog post | ||
[Building Custom Viz Plugins in Superset v2 (Updated for Monorepo)](https://preset.io/blog/building-custom-viz-plugins-in-superset-v2) blog post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have official docs for this - should we link to the docs or maybe both? https://superset.apache.org/docs/contributing/creating-viz-plugins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
SUMMARY
Updating to the newer link, which is more relevant for the current monorepo situation
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION