Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): add note about quote handling in filters #18657

Merged
merged 1 commit into from
Feb 10, 2022
Merged

chore(docs): add note about quote handling in filters #18657

merged 1 commit into from
Feb 10, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Feb 10, 2022 •
edited
Loading

SUMMARY

The recent PR #17881 introduced a breaking change on how trailing/leading quotes were handled on filter values. This adds a note to UPDATING.md to make users aware of the new behavior.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro
Copy link
Member Author

Ping @stephenLYZ , do you agree with the note?

serenajiang
serenajiang approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@serenajiang serenajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@villebro villebro merged commit 12cddb7 into apache:master Feb 10, 2022
@villebro villebro deleted the villebro/filter-quote-updating branch February 10, 2022 10:37
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenajiang serenajiang serenajiang approved these changes

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@villebro @zhaoyongjie @serenajiang @mistercrunch