chore: move data nav menu to plus menu #18629

pkdotson · 2022-02-09T04:17:41Z

SUMMARY

This pr more the upload csv, columnar, and excel links in the main nav from the data dropdown to the plus icon. This pr is first step in allowing the database modal to be used within the main nav and throughout the app.

After new changes:

Screen.Recording.2022-02-09.at.2.09.28.PM.mov

TESTING INSTRUCTIONS

Check for changes in the main nav.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

superset-frontend/src/views/components/Menu.tsx

codecov · 2022-02-09T22:56:38Z

Codecov Report

Merging #18629 (61a2756) into master (4ab0786) will decrease coverage by 0.16%.
The diff coverage is 82.35%.

❗ Current head 61a2756 differs from pull request most recent head 57e001c. Consider uploading reports for the commit 57e001c to get more accurate results

@@            Coverage Diff             @@
##           master   #18629      +/-   ##
==========================================
- Coverage   66.31%   66.15%   -0.17%     
==========================================
  Files        1620     1620              
  Lines       63080    63087       +7     
  Branches     6370     6372       +2     
==========================================
- Hits        41833    41733     -100     
- Misses      19591    19697     +106     
- Partials     1656     1657       +1

Flag	Coverage Δ
hive	`?`
javascript	`51.25% <78.57%> (+0.01%)`	⬆️
mysql	`81.42% <100.00%> (+<0.01%)`	⬆️
postgres	`81.47% <100.00%> (+<0.01%)`	⬆️
presto	`?`
python	`81.56% <100.00%> (-0.35%)`	⬇️
sqlite	`81.16% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts	`100.00% <ø> (ø)`
...board/components/nativeFilters/FilterBar/index.tsx	`69.82% <ø> (ø)`
superset-frontend/src/views/App.tsx	`0.00% <0.00%> (ø)`
superset/initialization/__init__.py	`90.65% <ø> (+0.45%)`	⬆️
...perset-frontend/src/views/components/MenuRight.tsx	`80.00% <81.81%> (-0.49%)`	⬇️
superset-frontend/src/views/components/Menu.tsx	`56.41% <100.00%> (+1.14%)`	⬆️
superset/views/base.py	`74.75% <100.00%> (+0.25%)`	⬆️
superset/db_engines/hive.py	`0.00% <0.00%> (-85.19%)`	⬇️
superset/db_engine_specs/hive.py	`70.27% <0.00%> (-15.45%)`	⬇️
superset/db_engine_specs/presto.py	`83.47% <0.00%> (-5.65%)`	⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab0786...57e001c. Read the comment docs.

superset-frontend/src/views/components/Menu.test.tsx

superset-frontend/src/views/components/Menu.tsx

superset-frontend/src/views/components/Menu.test.tsx

Co-authored-by: Hugh A. Miles II <[email protected]>

superset-frontend/src/views/components/Menu.test.tsx

into chore-change-nav

superset-frontend/src/views/components/Menu.tsx

superset-frontend/src/views/components/MenuRight.tsx

superset/views/base.py

superset-frontend/src/views/App.tsx

eschutho · 2022-02-16T20:58:11Z

superset-frontend/src/views/components/MenuRight.tsx

+                    className="data-menu"
+                    title={menuIconAndLabel(menu as MenuObjectProps)}
+                  >
+                    {menu.childs.map(item =>


This looks great!

eschutho · 2022-02-16T21:04:51Z

superset/views/base.py

+        bool(conf["CSV_EXTENSIONS"].intersection(conf["ALLOWED_EXTENSIONS"])),
+    )
+    frontend_config["COLUMNAR_EXTENSIONS"] = bool(
+        bool(conf["COLUMNAR_EXTENSIONS"].intersection(conf["ALLOWED_EXTENSIONS"])),


This looks good, but to further simplify, wdyt about adding these keys to the FRONTEND_CONF_KEYS and then do the logic on the client side component? In other words, instead of this file being concerned with logic or the usage of this data, it just passes the data to the client and then the client only has to be concerned about the logic.

sure to dry that out a bit it makes sense.

However I'm going to mark this as a follow up as this will add some testing layer on frontend I think.

ok, sounds good. thanks

superset-frontend/src/views/components/MenuRight.tsx

…hore-change-nav

eschutho

Super!

github-actions · 2022-02-17T01:37:36Z

Ephemeral environment shutdown and build artifacts deleted.

This reverts commit 2421d17.

more data nav menu

681c20e

superset-github-bot bot added the preset-io label Feb 9, 2022

pull-request-size bot added the size/M label Feb 9, 2022

fix lint and fix nav css

a4bbd5e

pkdotson marked this pull request as draft February 9, 2022 10:23

update test and remove icons

2ae8696

pull-request-size bot added size/L and removed size/M labels Feb 9, 2022

pkdotson requested review from hughhhh, eschutho and AAfghahi February 9, 2022 22:10

pkdotson marked this pull request as ready for review February 9, 2022 22:11

AAfghahi reviewed Feb 9, 2022

View reviewed changes

superset-frontend/src/views/components/Menu.tsx Outdated Show resolved Hide resolved

hughhhh reviewed Feb 10, 2022

View reviewed changes

superset-frontend/src/views/components/Menu.test.tsx Outdated Show resolved Hide resolved

hughhhh reviewed Feb 10, 2022

View reviewed changes

superset-frontend/src/views/components/Menu.tsx Outdated Show resolved Hide resolved

hughhhh reviewed Feb 10, 2022

View reviewed changes

superset-frontend/src/views/components/Menu.test.tsx Show resolved Hide resolved

Update superset-frontend/src/views/components/Menu.test.tsx

237263a

Co-authored-by: Hugh A. Miles II <[email protected]>

srinify added the design:user-research Related to user research label Feb 10, 2022

eschutho reviewed Feb 10, 2022

View reviewed changes

superset-frontend/src/views/components/Menu.test.tsx Outdated Show resolved Hide resolved

hughhhh reviewed Feb 10, 2022

View reviewed changes

superset-frontend/src/views/components/Menu.test.tsx Outdated Show resolved Hide resolved

hughhhh and others added 5 commits February 10, 2022 16:34

Apply suggestions from code review

04d1ff9

use backend app.link to show new nav changes

1c0f383

Merge branch 'chore-change-nav' of https://github.com/preset-io/superset

760d8c6

into chore-change-nav

fix lint

717c5bb

update test

2502a9a

pkdotson requested review from eschutho, AAfghahi and hughhhh February 10, 2022 22:24

eschutho reviewed Feb 11, 2022

View reviewed changes

superset-frontend/src/views/components/Menu.tsx Outdated Show resolved Hide resolved

pkdotson requested a review from eschutho February 15, 2022 00:26

pkdotson added 3 commits February 15, 2022 12:08

add allowed extensions to bootstrap and hard code links

a6c0bbe

remove backend links

0e9abe9

fix test

117261e

eschutho reviewed Feb 15, 2022

View reviewed changes

superset-frontend/src/views/components/Menu.tsx Outdated Show resolved Hide resolved

eschutho reviewed Feb 15, 2022

View reviewed changes

superset-frontend/src/views/components/MenuRight.tsx Outdated Show resolved Hide resolved

eschutho reviewed Feb 15, 2022

View reviewed changes

superset-frontend/src/views/components/MenuRight.tsx Outdated Show resolved Hide resolved

eschutho reviewed Feb 15, 2022

View reviewed changes

superset/views/base.py Outdated Show resolved Hide resolved

hughhhh reviewed Feb 15, 2022

View reviewed changes

superset-frontend/src/views/App.tsx Outdated Show resolved Hide resolved

add extensions to frontend conf

c42491d

pkdotson requested a review from eschutho February 16, 2022 01:14

pkdotson added 3 commits February 15, 2022 17:18

fix test and add be changes

9eac285

test is python test passes

6e9eb0c

update python test and reremove app links

9121e01

eschutho reviewed Feb 16, 2022

View reviewed changes

superset-frontend/src/views/components/MenuRight.tsx Show resolved Hide resolved

eschutho reviewed Feb 16, 2022

View reviewed changes

superset-frontend/src/views/components/MenuRight.tsx Outdated Show resolved Hide resolved

pkdotson added 2 commits February 16, 2022 14:52

Merge branch 'master' of https://github.com/preset-io/superset into c…

32f6e79

…hore-change-nav

fix ts and add t's

57e001c

eschutho approved these changes Feb 17, 2022

View reviewed changes

pkdotson merged commit 2421d17 into apache:master Feb 17, 2022

hughhhh pushed a commit to preset-io/superset that referenced this pull request Mar 7, 2022

Revert "chore: move data nav menu to plus menu (apache#18629)"

16ac4a7

This reverts commit 2421d17.

hughhhh added a commit to preset-io/superset that referenced this pull request Mar 7, 2022

Revert "chore: move data nav menu to plus menu (apache#18629)"

ce50d56

This reverts commit 2421d17.

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: move data nav menu to plus menu #18629

chore: move data nav menu to plus menu #18629

pkdotson commented Feb 9, 2022 •

edited

Loading

codecov bot commented Feb 9, 2022 •

edited

Loading

eschutho Feb 16, 2022

eschutho Feb 16, 2022

pkdotson Feb 16, 2022

pkdotson Feb 17, 2022

eschutho Feb 17, 2022

eschutho left a comment

github-actions bot commented Feb 17, 2022

chore: move data nav menu to plus menu #18629

chore: move data nav menu to plus menu #18629

Conversation

pkdotson commented Feb 9, 2022 • edited Loading

SUMMARY

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Feb 9, 2022 • edited Loading

Codecov Report

eschutho Feb 16, 2022

Choose a reason for hiding this comment

eschutho Feb 16, 2022

Choose a reason for hiding this comment

pkdotson Feb 16, 2022

Choose a reason for hiding this comment

pkdotson Feb 17, 2022

Choose a reason for hiding this comment

eschutho Feb 17, 2022

Choose a reason for hiding this comment

eschutho left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 17, 2022

pkdotson commented Feb 9, 2022 •

edited

Loading

codecov bot commented Feb 9, 2022 •

edited

Loading