feat: editable title xl certified badge #18626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork from origin
opus-42
changed the title
etr2460
changed the title
etr2460
approved these changes
Feb 9, 2022
jinghua-qa
pushed a commit
to jinghua-qa/superset
that referenced
this pull request
Feb 10, 2022
* Add size to EditableTitle certified badge * Lint EditableTitle file Co-authored-by: Emmanuel Bavoux <[email protected]> add native filter test for time grain filter
jinghua-qa
pushed a commit
to jinghua-qa/superset
that referenced
this pull request
Feb 10, 2022
* Add size to EditableTitle certified badge * Lint EditableTitle file Co-authored-by: Emmanuel Bavoux <[email protected]> add native filter test for time grain filter
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I propose to increase it the size of the Certified Badge to XL instead of L (default) when using it Editable Title.
Other certified badge size are left in default size.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
Go into a dashboard with certification. Badge with XL size should appear on the left of the title