Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate SliderControl to TypeScript & added story #18120

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

ad-m
Copy link
Contributor

@ad-m ad-m commented Jan 20, 2022

SUMMARY

Migrated SliderControl to TypeScript to apply direction outlined in #18100 .

In addition, added a new story to visualize that component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

obraz

TESTING INSTRUCTIONS

Storybook can be used to verify that changes.

ADDITIONAL INFORMATION

  • Has associated issue: see Migrate components to TypeScript #18100
  • Required feature flags: no
  • Changes UI: no
  • Includes DB Migration (follow approval process in SIP-59): no
    • Migration is atomic, supports rollback & is backwards-compatible: N/A
    • Confirm DB migration upgrade and downgrade tested: N/A
    • Runtime estimates and downtime expectations provided: N/A
  • Introduces new feature or API: no
  • Removes existing feature or API: no

@kgabryje , @asadUllah58 You might be interested in this PR!

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #18120 (d03c511) into master (1f81292) will increase coverage by 0.22%.
The diff coverage is 97.94%.

❗ Current head d03c511 differs from pull request most recent head 45947bc. Consider uploading reports for the commit 45947bc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18120      +/-   ##
==========================================
+ Coverage   65.74%   65.96%   +0.22%     
==========================================
  Files        1577     1584       +7     
  Lines       61807    62000     +193     
  Branches     6243     6243              
==========================================
+ Hits        40637    40901     +264     
+ Misses      19569    19498      -71     
  Partials     1601     1601              
Flag Coverage Δ
javascript 50.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/explore/components/controls/SliderControl.tsx 0.00% <0.00%> (ø)
superset/key_value/commands/entry.py 100.00% <ø> (ø)
superset/charts/form_data/commands/update.py 90.90% <90.90%> (ø)
superset/charts/form_data/commands/create.py 94.11% <94.11%> (ø)
superset/charts/form_data/commands/delete.py 94.73% <94.73%> (ø)
superset/charts/form_data/commands/get.py 95.65% <95.65%> (ø)
superset/charts/commands/exceptions.py 91.48% <100.00%> (+0.37%) ⬆️
superset/charts/form_data/api.py 100.00% <100.00%> (ø)
superset/charts/form_data/utils.py 100.00% <100.00%> (ø)
superset/config.py 91.74% <100.00%> (+0.02%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f81292...45947bc. Read the comment docs.

@ad-m
Copy link
Contributor Author

ad-m commented Feb 10, 2022

@kgabryje is there anything missing?

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for taking so long to approve!

@kgabryje kgabryje merged commit bd0b9f2 into apache:master Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants