-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate SliderControl to TypeScript & added story #18120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18120 +/- ##
==========================================
+ Coverage 65.74% 65.96% +0.22%
==========================================
Files 1577 1584 +7
Lines 61807 62000 +193
Branches 6243 6243
==========================================
+ Hits 40637 40901 +264
+ Misses 19569 19498 -71
Partials 1601 1601
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/explore/components/controls/SliderControl.tsx
Outdated
Show resolved
Hide resolved
@kgabryje is there anything missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for taking so long to approve!
SUMMARY
Migrated SliderControl to TypeScript to apply direction outlined in #18100 .
In addition, added a new story to visualize that component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Storybook can be used to verify that changes.
ADDITIONAL INFORMATION
@kgabryje , @asadUllah58 You might be interested in this PR!