refactor: migrate RowCountLabel to TypeScript & added story #18105

ad-m · 2022-01-20T08:21:59Z

SUMMARY

Non-fuctional change to migrate superset-frontend/src/explore/components/RowCountLabel.{jsx,tsx}.

In addiction story for RowCountLabel has been added. To use that storybook have been enabled for explore directory.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual changes:

TESTING INSTRUCTIONS

Use Storybook to see no visual & functional changes. You may also use build frontend.

ADDITIONAL INFORMATION

Has associated issue: see Migrate components to TypeScript #18100
Required feature flags: no
Changes UI: no
Includes DB Migration (follow approval process in SIP-59): no
- Migration is atomic, supports rollback & is backwards-compatible: N/A
- Confirm DB migration upgrade and downgrade tested: N/A
- Runtime estimates and downtime expectations provided: N/A
Introduces new feature or API: no
Removes existing feature or API: no

@kgabryje, cześć, czy byłbyś tak miły, aby na to spojrzeć? 😉

codecov · 2022-01-20T10:26:55Z

Codecov Report

Merging #18105 (ddedb2e) into master (035638c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #18105      +/-   ##
==========================================
- Coverage   65.86%   65.85%   -0.01%     
==========================================
  Files        1577     1577              
  Lines       61809    61806       -3     
  Branches     6242     6243       +1     
==========================================
- Hits        40708    40704       -4     
  Misses      19501    19501              
- Partials     1600     1601       +1

Flag	Coverage Δ
javascript	`50.91% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-frontend/src/explore/components/RowCountLabel.tsx	`88.88% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035638c...ddedb2e. Read the comment docs.

kgabryje · 2022-01-20T10:47:05Z

superset-frontend/src/explore/components/RowCountLabel.tsx

@@ -31,11 +31,20 @@ const propTypes = {
  loading: PropTypes.bool,
 };


Now that we use typescript we don't need propTypes anymore 🙂

Thanks for the clarification. I am not fully aware of project standards whether propTypes is not used in an unusual way, and have found TypeScript components in Superset to retain propTypes sometime.

Well spotted! I'm quite sure that's a mistake. @suddjian I think that's your piece of code, could you please confirm?

kgabryje · 2022-01-20T10:49:32Z

superset-frontend/src/explore/components/RowCountLabel.tsx

@@ -31,11 +31,20 @@ const propTypes = {
  loading: PropTypes.bool,
 };

+type RowCountLabelProps = {
+  rowcount?: number;


I think we should make the rowcount required

kgabryje · 2022-01-20T10:54:40Z

superset-frontend/src/explore/components/RowCountLabel.tsx

+type RowCountLabelProps = {
+  rowcount?: number;
+  limit?: number;
+  rows?: string;


I don't think we use prop rows here 🤔

You're right. I tried not to change more widely (this field was previously in propTypes) to facilitate the review, but - taking into account your comments - I will introduce such optimizations in future migrations as well.

Thanks for your comments. They are very valuable to me. At the beginning, I just wanted to touch small things to calibrate myself to the style, the expected unit of work in the project, so that our cooperation would go smoothly. There are a lot of components to migrate and I don't want to get stuck in a big PR review.

kgabryje · 2022-01-20T10:58:30Z

superset-frontend/src/explore/components/RowCountLabel.tsx

+  suffix?: string;
+  loading?: boolean;
+};
+
 const defaultProps = {


To make sure that defaultProps types are compatible with RowCountLabelProps, we should either add & typeof defaultProps to type definition or... get rid of defaultProps and just use ES6 default values like const { rowcount, limit, suffix = t('rows'), loading } = props;.
According to https://react-typescript-cheatsheet.netlify.app/docs/basic/getting-started/default_props/, the second solution is preferred

You're right, when removing defaultProps while removing propTypes I changed it this way right away, according to the current convention.

kgabryje · 2022-01-20T11:00:28Z

Thank you for the contribution, such work is always soo appreciated 🙂 I left a few small comments, but other than that the PR looks great!

kgabryje · 2022-01-20T11:16:44Z

superset-frontend/src/explore/components/RowCountLabel.stories.tsx

+
+const options = {
+  loading: {
+    loading: true,


I think we need to either add rowcount: 0 here or set rowcount = 0 as a default value in the component. Now we get a red "danger" colour in storybook, which shouldn't happen.

kgabryje

LGTM!

* fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (#18037) * Update superset-e2e.yml (#18041) * Revert "Update superset-e2e.yml (#18041)" (#18051) This reverts commit b565273. * feat: Trino Authentications (#17593) * feat: support Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * docs: Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * chore(supeset.utils.core): move all database utils to database utils module (#18058) * chore(plugin-chart-echarts): add types to controls (#18059) * fix(generator): more cleanup to plugin framework (#18027) * fix(generator): more cleanup to plugin framework * fix typo and package name * add docs * fix typo * Update superset-frontend/webpack.config.js Co-authored-by: Kamil Gabryjelski <[email protected]> * fix generator reference * add steps to tutorial and fix package version * refine docs/readme Co-authored-by: Kamil Gabryjelski <[email protected]> * feat(advanced analytics): support groupby in resample (#18045) * fix(dashboard): scope of nativefilter not update (#18048) * fix(generator): add lockfile and fix styling issues (#18073) * fix(generator): add lockfile and fix styling issues * fix margins and remove redundant scroll * update tutorial * refactor(sql_lab): SQL Lab Persistent Saved State (#17771) * a lot of console logs * testing * test * added saved_query to remoteId * created useEffect so that title properly changes in modal * Update superset-frontend/src/SqlLab/actions/sqlLab.js Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> * refactor(example_data): replace the way the birth_names data is loaded to DB (#18060) * refactor: replace the way the birth_names data is loaded to DB * fix failed unit test * fix failed unit test * fix failed tests * fix pass wrong flag of support datetime type * remove unused fixture * feat: add chart description in info tooltip (#17207) * feat: add chart list description * fix: text overflow * fix: text-overflow with line-height * Correction of proper names format in README (#18087) * chore: added SEO routes * fix can't use examples helpers on non app context based environment (#18086) * chore: split CLI into multiple files (#18082) * chore: split CLI into multiple files * Update tests * Who fixes the fixtures? * Add subcommands dynamically * Rebase * fix misspelling (#18097) * refactor: sqleditorleftbar to functional (#17807) * Working on converting sqleditorleftbar to functional component * Creating draft PR to address bug * Still working on solving re rendering bug * infinite rerender fix * Creating draft PR to address bug * Cleaning up in preparation for push * Made changes suggested by Elizabeth * Fixed issues as per Lindsey's comment Co-authored-by: Arash <[email protected]> * fix rat excludes and headers * fix(docs): fix path of image for "Create New Chart" (#18089) * Migrate Checkbox story to tsx - see #18100 (#18101) Looks good! * refactor: migrate RowCountLabel to TypeScript & added story (#18105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel * fix: logging warning on dataframe (don't use python's warnings) (#18111) * fix: logging warning on dataframe (don't use python's warnings) * lint * update changelog and updating for 1.4.0 (#18083) * feat: Adds a key-value endpoint to store charts form data (#17882) * feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access * fix(explore): fix chart embed code modal glitch (#17843) * feat(plugin-chart-echarts): support non-timeseries x-axis (#17917) * feat(plugin-chart-echarts): support non-timeseries x-axis * fix tests * change formula return type from Date to number * add x_axis test coverage * rename func and improve coverage * add x-axis control to bar chart * remove redundant console.log * fix description * make x-axis control mandatory * 🙃 * fix x-axis formatter * fix showValues * fix implicit rDTTM_ALIAS references in postProcessing * replace TIME_COLUMN with DTTM_ALIAS * fix remaining implicit indexes * fix: Disable filtering on wide result sets (#18021) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (#18037) * add missing is_timeseries to pivot op Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> * feat(country-map): added new countries in country-chart-map (#18081) * chore: migrating storybook jsx to typescript #18100 (#18133) * Migrating storybook jsx to typescript #18100 * Migrating storybook jsx to typescript Co-authored-by: Jayakrishnan Karolil <[email protected]> * feat(annotation): add toast feedback to annotation templates (#18116) * feat(dashboard): add toast feedback to dashboard actions (#18114) * feat(explore): more toast feedback on user actions in Explore (#18108) * feat(explore): add toasts feedback when user copies chart url * Show toast message when updating chart properties * Change toast type to success when saving chart * Use success toast from props * Fix tests * Use withToasts instead of dispatch * Use PropertiesModalProps instead of any * Docs: fix typo (#18125) * fix: undefined error when adding extra sequential color scheme (#18152) * feat: allow assets to be managed externally (#18093) * feat: allow assets to be managed externally * Use server_default * chore: use pkg_resources for cleaner config (#18130) * refactor: Moves the Explore form_data endpoint (#18151) * refactor: Moves the Explore form_data endpoint * Removes unused imports * Fixes openapi schema error * Fixes typo * Renames and UPDATING.md Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]>

* setup docusaurus * rename * add introduction content * chore(docsV2): move content from docs to docsV2 (#17714) * add FAQs and contribution pages * chore: add api, security, and roadmap pages, include swaggerui in dependency for api page * chore: move api page header below imports * chore: change API page info alert to use built in Infima class instead of custom class Co-authored-by: Corbin Robb <[email protected]> * chore(docs-v2): moving more markdown content to new documentation site (#17736) * chore: move markdown content and images for docs installation directory to docs-v2 * chore: move docs miscellaneous directory content to docs-v2 * chore(docs-v2): move over connecting to databases content and rename some files to .mdx Co-authored-by: Corbin Robb <[email protected]> * Update styling and logo (#17990) * update styling * update colors * chore(docs-v2): remove blog and tutorial and update some styling (#17929) * add superset logo and favicon, change styles to better match current docs, add prettierrc * change file types to mdx * Add simple superset dark mode freindly logo * clean up default pages - blog and tutorial docs Co-authored-by: Corbin Robb <[email protected]> * Chore: moving charts and dashboard to docusaurus (#18036) * add contributing add creating charts and dashboards * delete extra images * update rat-excludes * Port homepage (#18115) * Port community page (#18128) * chore: add seo redirects for Docs v@ (#18092) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (#18037) * Update superset-e2e.yml (#18041) * Revert "Update superset-e2e.yml (#18041)" (#18051) This reverts commit b565273. * feat: Trino Authentications (#17593) * feat: support Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * docs: Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * chore(supeset.utils.core): move all database utils to database utils module (#18058) * chore(plugin-chart-echarts): add types to controls (#18059) * fix(generator): more cleanup to plugin framework (#18027) * fix(generator): more cleanup to plugin framework * fix typo and package name * add docs * fix typo * Update superset-frontend/webpack.config.js Co-authored-by: Kamil Gabryjelski <[email protected]> * fix generator reference * add steps to tutorial and fix package version * refine docs/readme Co-authored-by: Kamil Gabryjelski <[email protected]> * feat(advanced analytics): support groupby in resample (#18045) * fix(dashboard): scope of nativefilter not update (#18048) * fix(generator): add lockfile and fix styling issues (#18073) * fix(generator): add lockfile and fix styling issues * fix margins and remove redundant scroll * update tutorial * refactor(sql_lab): SQL Lab Persistent Saved State (#17771) * a lot of console logs * testing * test * added saved_query to remoteId * created useEffect so that title properly changes in modal * Update superset-frontend/src/SqlLab/actions/sqlLab.js Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> * refactor(example_data): replace the way the birth_names data is loaded to DB (#18060) * refactor: replace the way the birth_names data is loaded to DB * fix failed unit test * fix failed unit test * fix failed tests * fix pass wrong flag of support datetime type * remove unused fixture * feat: add chart description in info tooltip (#17207) * feat: add chart list description * fix: text overflow * fix: text-overflow with line-height * Correction of proper names format in README (#18087) * chore: added SEO routes * fix can't use examples helpers on non app context based environment (#18086) * chore: split CLI into multiple files (#18082) * chore: split CLI into multiple files * Update tests * Who fixes the fixtures? * Add subcommands dynamically * Rebase * fix misspelling (#18097) * refactor: sqleditorleftbar to functional (#17807) * Working on converting sqleditorleftbar to functional component * Creating draft PR to address bug * Still working on solving re rendering bug * infinite rerender fix * Creating draft PR to address bug * Cleaning up in preparation for push * Made changes suggested by Elizabeth * Fixed issues as per Lindsey's comment Co-authored-by: Arash <[email protected]> * fix rat excludes and headers * fix(docs): fix path of image for "Create New Chart" (#18089) * Migrate Checkbox story to tsx - see #18100 (#18101) Looks good! * refactor: migrate RowCountLabel to TypeScript & added story (#18105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel * fix: logging warning on dataframe (don't use python's warnings) (#18111) * fix: logging warning on dataframe (don't use python's warnings) * lint * update changelog and updating for 1.4.0 (#18083) * feat: Adds a key-value endpoint to store charts form data (#17882) * feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access * fix(explore): fix chart embed code modal glitch (#17843) * feat(plugin-chart-echarts): support non-timeseries x-axis (#17917) * feat(plugin-chart-echarts): support non-timeseries x-axis * fix tests * change formula return type from Date to number * add x_axis test coverage * rename func and improve coverage * add x-axis control to bar chart * remove redundant console.log * fix description * make x-axis control mandatory * 🙃 * fix x-axis formatter * fix showValues * fix implicit rDTTM_ALIAS references in postProcessing * replace TIME_COLUMN with DTTM_ALIAS * fix remaining implicit indexes * fix: Disable filtering on wide result sets (#18021) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (#18037) * add missing is_timeseries to pivot op Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> * feat(country-map): added new countries in country-chart-map (#18081) * chore: migrating storybook jsx to typescript #18100 (#18133) * Migrating storybook jsx to typescript #18100 * Migrating storybook jsx to typescript Co-authored-by: Jayakrishnan Karolil <[email protected]> * feat(annotation): add toast feedback to annotation templates (#18116) * feat(dashboard): add toast feedback to dashboard actions (#18114) * feat(explore): more toast feedback on user actions in Explore (#18108) * feat(explore): add toasts feedback when user copies chart url * Show toast message when updating chart properties * Change toast type to success when saving chart * Use success toast from props * Fix tests * Use withToasts instead of dispatch * Use PropertiesModalProps instead of any * Docs: fix typo (#18125) * fix: undefined error when adding extra sequential color scheme (#18152) * feat: allow assets to be managed externally (#18093) * feat: allow assets to be managed externally * Use server_default * chore: use pkg_resources for cleaner config (#18130) * refactor: Moves the Explore form_data endpoint (#18151) * refactor: Moves the Explore form_data endpoint * Removes unused imports * Fixes openapi schema error * Fixes typo * Renames and UPDATING.md Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]> * remove unneeded requirement Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Daniel W <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Srini Kadamati <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]>

* setup docusaurus * rename * add introduction content * chore(docsV2): move content from docs to docsV2 (#17714) * add FAQs and contribution pages * chore: add api, security, and roadmap pages, include swaggerui in dependency for api page * chore: move api page header below imports * chore: change API page info alert to use built in Infima class instead of custom class Co-authored-by: Corbin Robb <[email protected]> * chore(docs-v2): moving more markdown content to new documentation site (#17736) * chore: move markdown content and images for docs installation directory to docs-v2 * chore: move docs miscellaneous directory content to docs-v2 * chore(docs-v2): move over connecting to databases content and rename some files to .mdx Co-authored-by: Corbin Robb <[email protected]> * Update styling and logo (#17990) * update styling * update colors * chore(docs-v2): remove blog and tutorial and update some styling (#17929) * add superset logo and favicon, change styles to better match current docs, add prettierrc * change file types to mdx * Add simple superset dark mode freindly logo * clean up default pages - blog and tutorial docs Co-authored-by: Corbin Robb <[email protected]> * Chore: moving charts and dashboard to docusaurus (#18036) * add contributing add creating charts and dashboards * delete extra images * update rat-excludes * Port homepage (#18115) * Port community page (#18128) * chore: add seo redirects for Docs v@ (#18092) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (#18037) * Update superset-e2e.yml (#18041) * Revert "Update superset-e2e.yml (#18041)" (#18051) This reverts commit b565273. * feat: Trino Authentications (#17593) * feat: support Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * docs: Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * chore(supeset.utils.core): move all database utils to database utils module (#18058) * chore(plugin-chart-echarts): add types to controls (#18059) * fix(generator): more cleanup to plugin framework (#18027) * fix(generator): more cleanup to plugin framework * fix typo and package name * add docs * fix typo * Update superset-frontend/webpack.config.js Co-authored-by: Kamil Gabryjelski <[email protected]> * fix generator reference * add steps to tutorial and fix package version * refine docs/readme Co-authored-by: Kamil Gabryjelski <[email protected]> * feat(advanced analytics): support groupby in resample (#18045) * fix(dashboard): scope of nativefilter not update (#18048) * fix(generator): add lockfile and fix styling issues (#18073) * fix(generator): add lockfile and fix styling issues * fix margins and remove redundant scroll * update tutorial * refactor(sql_lab): SQL Lab Persistent Saved State (#17771) * a lot of console logs * testing * test * added saved_query to remoteId * created useEffect so that title properly changes in modal * Update superset-frontend/src/SqlLab/actions/sqlLab.js Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> * refactor(example_data): replace the way the birth_names data is loaded to DB (#18060) * refactor: replace the way the birth_names data is loaded to DB * fix failed unit test * fix failed unit test * fix failed tests * fix pass wrong flag of support datetime type * remove unused fixture * feat: add chart description in info tooltip (#17207) * feat: add chart list description * fix: text overflow * fix: text-overflow with line-height * Correction of proper names format in README (#18087) * chore: added SEO routes * fix can't use examples helpers on non app context based environment (#18086) * chore: split CLI into multiple files (#18082) * chore: split CLI into multiple files * Update tests * Who fixes the fixtures? * Add subcommands dynamically * Rebase * fix misspelling (#18097) * refactor: sqleditorleftbar to functional (#17807) * Working on converting sqleditorleftbar to functional component * Creating draft PR to address bug * Still working on solving re rendering bug * infinite rerender fix * Creating draft PR to address bug * Cleaning up in preparation for push * Made changes suggested by Elizabeth * Fixed issues as per Lindsey's comment Co-authored-by: Arash <[email protected]> * fix rat excludes and headers * fix(docs): fix path of image for "Create New Chart" (#18089) * Migrate Checkbox story to tsx - see #18100 (#18101) Looks good! * refactor: migrate RowCountLabel to TypeScript & added story (#18105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel * fix: logging warning on dataframe (don't use python's warnings) (#18111) * fix: logging warning on dataframe (don't use python's warnings) * lint * update changelog and updating for 1.4.0 (#18083) * feat: Adds a key-value endpoint to store charts form data (#17882) * feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access * fix(explore): fix chart embed code modal glitch (#17843) * feat(plugin-chart-echarts): support non-timeseries x-axis (#17917) * feat(plugin-chart-echarts): support non-timeseries x-axis * fix tests * change formula return type from Date to number * add x_axis test coverage * rename func and improve coverage * add x-axis control to bar chart * remove redundant console.log * fix description * make x-axis control mandatory * 🙃 * fix x-axis formatter * fix showValues * fix implicit rDTTM_ALIAS references in postProcessing * replace TIME_COLUMN with DTTM_ALIAS * fix remaining implicit indexes * fix: Disable filtering on wide result sets (#18021) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (#18037) * add missing is_timeseries to pivot op Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> * feat(country-map): added new countries in country-chart-map (#18081) * chore: migrating storybook jsx to typescript #18100 (#18133) * Migrating storybook jsx to typescript #18100 * Migrating storybook jsx to typescript Co-authored-by: Jayakrishnan Karolil <[email protected]> * feat(annotation): add toast feedback to annotation templates (#18116) * feat(dashboard): add toast feedback to dashboard actions (#18114) * feat(explore): more toast feedback on user actions in Explore (#18108) * feat(explore): add toasts feedback when user copies chart url * Show toast message when updating chart properties * Change toast type to success when saving chart * Use success toast from props * Fix tests * Use withToasts instead of dispatch * Use PropertiesModalProps instead of any * Docs: fix typo (#18125) * fix: undefined error when adding extra sequential color scheme (#18152) * feat: allow assets to be managed externally (#18093) * feat: allow assets to be managed externally * Use server_default * chore: use pkg_resources for cleaner config (#18130) * refactor: Moves the Explore form_data endpoint (#18151) * refactor: Moves the Explore form_data endpoint * Removes unused imports * Fixes openapi schema error * Fixes typo * Renames and UPDATING.md Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]> * fix up links * Fix whitespace * Remove unwanted change * Add apache links Co-authored-by: hughhhh <[email protected]> Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Daniel W <[email protected]> Co-authored-by: Srini Kadamati <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]>

* setup docusaurus * rename * add introduction content * chore(docsV2): move content from docs to docsV2 (#17714) * add FAQs and contribution pages * chore: add api, security, and roadmap pages, include swaggerui in dependency for api page * chore: move api page header below imports * chore: change API page info alert to use built in Infima class instead of custom class Co-authored-by: Corbin Robb <[email protected]> * chore(docs-v2): moving more markdown content to new documentation site (#17736) * chore: move markdown content and images for docs installation directory to docs-v2 * chore: move docs miscellaneous directory content to docs-v2 * chore(docs-v2): move over connecting to databases content and rename some files to .mdx Co-authored-by: Corbin Robb <[email protected]> * Update styling and logo (#17990) * update styling * update colors * chore(docs-v2): remove blog and tutorial and update some styling (#17929) * add superset logo and favicon, change styles to better match current docs, add prettierrc * change file types to mdx * Add simple superset dark mode freindly logo * clean up default pages - blog and tutorial docs Co-authored-by: Corbin Robb <[email protected]> * Chore: moving charts and dashboard to docusaurus (#18036) * add contributing add creating charts and dashboards * delete extra images * update rat-excludes * Port homepage (#18115) * Port community page (#18128) * chore: add seo redirects for Docs v@ (#18092) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (#18037) * Update superset-e2e.yml (#18041) * Revert "Update superset-e2e.yml (#18041)" (#18051) This reverts commit b565273. * feat: Trino Authentications (#17593) * feat: support Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * docs: Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * chore(supeset.utils.core): move all database utils to database utils module (#18058) * chore(plugin-chart-echarts): add types to controls (#18059) * fix(generator): more cleanup to plugin framework (#18027) * fix(generator): more cleanup to plugin framework * fix typo and package name * add docs * fix typo * Update superset-frontend/webpack.config.js Co-authored-by: Kamil Gabryjelski <[email protected]> * fix generator reference * add steps to tutorial and fix package version * refine docs/readme Co-authored-by: Kamil Gabryjelski <[email protected]> * feat(advanced analytics): support groupby in resample (#18045) * fix(dashboard): scope of nativefilter not update (#18048) * fix(generator): add lockfile and fix styling issues (#18073) * fix(generator): add lockfile and fix styling issues * fix margins and remove redundant scroll * update tutorial * refactor(sql_lab): SQL Lab Persistent Saved State (#17771) * a lot of console logs * testing * test * added saved_query to remoteId * created useEffect so that title properly changes in modal * Update superset-frontend/src/SqlLab/actions/sqlLab.js Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> * refactor(example_data): replace the way the birth_names data is loaded to DB (#18060) * refactor: replace the way the birth_names data is loaded to DB * fix failed unit test * fix failed unit test * fix failed tests * fix pass wrong flag of support datetime type * remove unused fixture * feat: add chart description in info tooltip (#17207) * feat: add chart list description * fix: text overflow * fix: text-overflow with line-height * Correction of proper names format in README (#18087) * chore: added SEO routes * fix can't use examples helpers on non app context based environment (#18086) * chore: split CLI into multiple files (#18082) * chore: split CLI into multiple files * Update tests * Who fixes the fixtures? * Add subcommands dynamically * Rebase * fix misspelling (#18097) * refactor: sqleditorleftbar to functional (#17807) * Working on converting sqleditorleftbar to functional component * Creating draft PR to address bug * Still working on solving re rendering bug * infinite rerender fix * Creating draft PR to address bug * Cleaning up in preparation for push * Made changes suggested by Elizabeth * Fixed issues as per Lindsey's comment Co-authored-by: Arash <[email protected]> * fix rat excludes and headers * fix(docs): fix path of image for "Create New Chart" (#18089) * Migrate Checkbox story to tsx - see #18100 (#18101) Looks good! * refactor: migrate RowCountLabel to TypeScript & added story (#18105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel * fix: logging warning on dataframe (don't use python's warnings) (#18111) * fix: logging warning on dataframe (don't use python's warnings) * lint * update changelog and updating for 1.4.0 (#18083) * feat: Adds a key-value endpoint to store charts form data (#17882) * feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access * fix(explore): fix chart embed code modal glitch (#17843) * feat(plugin-chart-echarts): support non-timeseries x-axis (#17917) * feat(plugin-chart-echarts): support non-timeseries x-axis * fix tests * change formula return type from Date to number * add x_axis test coverage * rename func and improve coverage * add x-axis control to bar chart * remove redundant console.log * fix description * make x-axis control mandatory * 🙃 * fix x-axis formatter * fix showValues * fix implicit rDTTM_ALIAS references in postProcessing * replace TIME_COLUMN with DTTM_ALIAS * fix remaining implicit indexes * fix: Disable filtering on wide result sets (#18021) * fix: handle null values in time-series table (#18039) * cleanup column_type_mappings (#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (#18037) * add missing is_timeseries to pivot op Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> * feat(country-map): added new countries in country-chart-map (#18081) * chore: migrating storybook jsx to typescript #18100 (#18133) * Migrating storybook jsx to typescript #18100 * Migrating storybook jsx to typescript Co-authored-by: Jayakrishnan Karolil <[email protected]> * feat(annotation): add toast feedback to annotation templates (#18116) * feat(dashboard): add toast feedback to dashboard actions (#18114) * feat(explore): more toast feedback on user actions in Explore (#18108) * feat(explore): add toasts feedback when user copies chart url * Show toast message when updating chart properties * Change toast type to success when saving chart * Use success toast from props * Fix tests * Use withToasts instead of dispatch * Use PropertiesModalProps instead of any * Docs: fix typo (#18125) * fix: undefined error when adding extra sequential color scheme (#18152) * feat: allow assets to be managed externally (#18093) * feat: allow assets to be managed externally * Use server_default * chore: use pkg_resources for cleaner config (#18130) * refactor: Moves the Explore form_data endpoint (#18151) * refactor: Moves the Explore form_data endpoint * Removes unused imports * Fixes openapi schema error * Fixes typo * Renames and UPDATING.md Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]> * Fix broken build * Revert unwanted change Co-authored-by: hughhhh <[email protected]> Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Daniel W <[email protected]> Co-authored-by: Srini Kadamati <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]>

…8105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel

* setup docusaurus * rename * add introduction content * chore(docsV2): move content from docs to docsV2 (apache#17714) * add FAQs and contribution pages * chore: add api, security, and roadmap pages, include swaggerui in dependency for api page * chore: move api page header below imports * chore: change API page info alert to use built in Infima class instead of custom class Co-authored-by: Corbin Robb <[email protected]> * chore(docs-v2): moving more markdown content to new documentation site (apache#17736) * chore: move markdown content and images for docs installation directory to docs-v2 * chore: move docs miscellaneous directory content to docs-v2 * chore(docs-v2): move over connecting to databases content and rename some files to .mdx Co-authored-by: Corbin Robb <[email protected]> * Update styling and logo (apache#17990) * update styling * update colors * chore(docs-v2): remove blog and tutorial and update some styling (apache#17929) * add superset logo and favicon, change styles to better match current docs, add prettierrc * change file types to mdx * Add simple superset dark mode freindly logo * clean up default pages - blog and tutorial docs Co-authored-by: Corbin Robb <[email protected]> * Chore: moving charts and dashboard to docusaurus (apache#18036) * add contributing add creating charts and dashboards * delete extra images * update rat-excludes * Port homepage (apache#18115) * Port community page (apache#18128) * chore: add seo redirects for Docs v@ (apache#18092) * fix: handle null values in time-series table (apache#18039) * cleanup column_type_mappings (apache#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (apache#18037) * Update superset-e2e.yml (apache#18041) * Revert "Update superset-e2e.yml (apache#18041)" (apache#18051) This reverts commit b565273. * feat: Trino Authentications (apache#17593) * feat: support Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * docs: Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * chore(supeset.utils.core): move all database utils to database utils module (apache#18058) * chore(plugin-chart-echarts): add types to controls (apache#18059) * fix(generator): more cleanup to plugin framework (apache#18027) * fix(generator): more cleanup to plugin framework * fix typo and package name * add docs * fix typo * Update superset-frontend/webpack.config.js Co-authored-by: Kamil Gabryjelski <[email protected]> * fix generator reference * add steps to tutorial and fix package version * refine docs/readme Co-authored-by: Kamil Gabryjelski <[email protected]> * feat(advanced analytics): support groupby in resample (apache#18045) * fix(dashboard): scope of nativefilter not update (apache#18048) * fix(generator): add lockfile and fix styling issues (apache#18073) * fix(generator): add lockfile and fix styling issues * fix margins and remove redundant scroll * update tutorial * refactor(sql_lab): SQL Lab Persistent Saved State (apache#17771) * a lot of console logs * testing * test * added saved_query to remoteId * created useEffect so that title properly changes in modal * Update superset-frontend/src/SqlLab/actions/sqlLab.js Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> * refactor(example_data): replace the way the birth_names data is loaded to DB (apache#18060) * refactor: replace the way the birth_names data is loaded to DB * fix failed unit test * fix failed unit test * fix failed tests * fix pass wrong flag of support datetime type * remove unused fixture * feat: add chart description in info tooltip (apache#17207) * feat: add chart list description * fix: text overflow * fix: text-overflow with line-height * Correction of proper names format in README (apache#18087) * chore: added SEO routes * fix can't use examples helpers on non app context based environment (apache#18086) * chore: split CLI into multiple files (apache#18082) * chore: split CLI into multiple files * Update tests * Who fixes the fixtures? * Add subcommands dynamically * Rebase * fix misspelling (apache#18097) * refactor: sqleditorleftbar to functional (apache#17807) * Working on converting sqleditorleftbar to functional component * Creating draft PR to address bug * Still working on solving re rendering bug * infinite rerender fix * Creating draft PR to address bug * Cleaning up in preparation for push * Made changes suggested by Elizabeth * Fixed issues as per Lindsey's comment Co-authored-by: Arash <[email protected]> * fix rat excludes and headers * fix(docs): fix path of image for "Create New Chart" (apache#18089) * Migrate Checkbox story to tsx - see apache#18100 (apache#18101) Looks good! * refactor: migrate RowCountLabel to TypeScript & added story (apache#18105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel * fix: logging warning on dataframe (don't use python's warnings) (apache#18111) * fix: logging warning on dataframe (don't use python's warnings) * lint * update changelog and updating for 1.4.0 (apache#18083) * feat: Adds a key-value endpoint to store charts form data (apache#17882) * feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access * fix(explore): fix chart embed code modal glitch (apache#17843) * feat(plugin-chart-echarts): support non-timeseries x-axis (apache#17917) * feat(plugin-chart-echarts): support non-timeseries x-axis * fix tests * change formula return type from Date to number * add x_axis test coverage * rename func and improve coverage * add x-axis control to bar chart * remove redundant console.log * fix description * make x-axis control mandatory * 🙃 * fix x-axis formatter * fix showValues * fix implicit rDTTM_ALIAS references in postProcessing * replace TIME_COLUMN with DTTM_ALIAS * fix remaining implicit indexes * fix: Disable filtering on wide result sets (apache#18021) * fix: handle null values in time-series table (apache#18039) * cleanup column_type_mappings (apache#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (apache#18037) * add missing is_timeseries to pivot op Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> * feat(country-map): added new countries in country-chart-map (apache#18081) * chore: migrating storybook jsx to typescript apache#18100 (apache#18133) * Migrating storybook jsx to typescript apache#18100 * Migrating storybook jsx to typescript Co-authored-by: Jayakrishnan Karolil <[email protected]> * feat(annotation): add toast feedback to annotation templates (apache#18116) * feat(dashboard): add toast feedback to dashboard actions (apache#18114) * feat(explore): more toast feedback on user actions in Explore (apache#18108) * feat(explore): add toasts feedback when user copies chart url * Show toast message when updating chart properties * Change toast type to success when saving chart * Use success toast from props * Fix tests * Use withToasts instead of dispatch * Use PropertiesModalProps instead of any * Docs: fix typo (apache#18125) * fix: undefined error when adding extra sequential color scheme (apache#18152) * feat: allow assets to be managed externally (apache#18093) * feat: allow assets to be managed externally * Use server_default * chore: use pkg_resources for cleaner config (apache#18130) * refactor: Moves the Explore form_data endpoint (apache#18151) * refactor: Moves the Explore form_data endpoint * Removes unused imports * Fixes openapi schema error * Fixes typo * Renames and UPDATING.md Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]> * remove unneeded requirement Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Daniel W <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Srini Kadamati <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]>

* setup docusaurus * rename * add introduction content * chore(docsV2): move content from docs to docsV2 (apache#17714) * add FAQs and contribution pages * chore: add api, security, and roadmap pages, include swaggerui in dependency for api page * chore: move api page header below imports * chore: change API page info alert to use built in Infima class instead of custom class Co-authored-by: Corbin Robb <[email protected]> * chore(docs-v2): moving more markdown content to new documentation site (apache#17736) * chore: move markdown content and images for docs installation directory to docs-v2 * chore: move docs miscellaneous directory content to docs-v2 * chore(docs-v2): move over connecting to databases content and rename some files to .mdx Co-authored-by: Corbin Robb <[email protected]> * Update styling and logo (apache#17990) * update styling * update colors * chore(docs-v2): remove blog and tutorial and update some styling (apache#17929) * add superset logo and favicon, change styles to better match current docs, add prettierrc * change file types to mdx * Add simple superset dark mode freindly logo * clean up default pages - blog and tutorial docs Co-authored-by: Corbin Robb <[email protected]> * Chore: moving charts and dashboard to docusaurus (apache#18036) * add contributing add creating charts and dashboards * delete extra images * update rat-excludes * Port homepage (apache#18115) * Port community page (apache#18128) * chore: add seo redirects for Docs v@ (apache#18092) * fix: handle null values in time-series table (apache#18039) * cleanup column_type_mappings (apache#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (apache#18037) * Update superset-e2e.yml (apache#18041) * Revert "Update superset-e2e.yml (apache#18041)" (apache#18051) This reverts commit b565273. * feat: Trino Authentications (apache#17593) * feat: support Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * docs: Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * chore(supeset.utils.core): move all database utils to database utils module (apache#18058) * chore(plugin-chart-echarts): add types to controls (apache#18059) * fix(generator): more cleanup to plugin framework (apache#18027) * fix(generator): more cleanup to plugin framework * fix typo and package name * add docs * fix typo * Update superset-frontend/webpack.config.js Co-authored-by: Kamil Gabryjelski <[email protected]> * fix generator reference * add steps to tutorial and fix package version * refine docs/readme Co-authored-by: Kamil Gabryjelski <[email protected]> * feat(advanced analytics): support groupby in resample (apache#18045) * fix(dashboard): scope of nativefilter not update (apache#18048) * fix(generator): add lockfile and fix styling issues (apache#18073) * fix(generator): add lockfile and fix styling issues * fix margins and remove redundant scroll * update tutorial * refactor(sql_lab): SQL Lab Persistent Saved State (apache#17771) * a lot of console logs * testing * test * added saved_query to remoteId * created useEffect so that title properly changes in modal * Update superset-frontend/src/SqlLab/actions/sqlLab.js Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> * refactor(example_data): replace the way the birth_names data is loaded to DB (apache#18060) * refactor: replace the way the birth_names data is loaded to DB * fix failed unit test * fix failed unit test * fix failed tests * fix pass wrong flag of support datetime type * remove unused fixture * feat: add chart description in info tooltip (apache#17207) * feat: add chart list description * fix: text overflow * fix: text-overflow with line-height * Correction of proper names format in README (apache#18087) * chore: added SEO routes * fix can't use examples helpers on non app context based environment (apache#18086) * chore: split CLI into multiple files (apache#18082) * chore: split CLI into multiple files * Update tests * Who fixes the fixtures? * Add subcommands dynamically * Rebase * fix misspelling (apache#18097) * refactor: sqleditorleftbar to functional (apache#17807) * Working on converting sqleditorleftbar to functional component * Creating draft PR to address bug * Still working on solving re rendering bug * infinite rerender fix * Creating draft PR to address bug * Cleaning up in preparation for push * Made changes suggested by Elizabeth * Fixed issues as per Lindsey's comment Co-authored-by: Arash <[email protected]> * fix rat excludes and headers * fix(docs): fix path of image for "Create New Chart" (apache#18089) * Migrate Checkbox story to tsx - see apache#18100 (apache#18101) Looks good! * refactor: migrate RowCountLabel to TypeScript & added story (apache#18105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel * fix: logging warning on dataframe (don't use python's warnings) (apache#18111) * fix: logging warning on dataframe (don't use python's warnings) * lint * update changelog and updating for 1.4.0 (apache#18083) * feat: Adds a key-value endpoint to store charts form data (apache#17882) * feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access * fix(explore): fix chart embed code modal glitch (apache#17843) * feat(plugin-chart-echarts): support non-timeseries x-axis (apache#17917) * feat(plugin-chart-echarts): support non-timeseries x-axis * fix tests * change formula return type from Date to number * add x_axis test coverage * rename func and improve coverage * add x-axis control to bar chart * remove redundant console.log * fix description * make x-axis control mandatory * 🙃 * fix x-axis formatter * fix showValues * fix implicit rDTTM_ALIAS references in postProcessing * replace TIME_COLUMN with DTTM_ALIAS * fix remaining implicit indexes * fix: Disable filtering on wide result sets (apache#18021) * fix: handle null values in time-series table (apache#18039) * cleanup column_type_mappings (apache#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (apache#18037) * add missing is_timeseries to pivot op Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> * feat(country-map): added new countries in country-chart-map (apache#18081) * chore: migrating storybook jsx to typescript apache#18100 (apache#18133) * Migrating storybook jsx to typescript apache#18100 * Migrating storybook jsx to typescript Co-authored-by: Jayakrishnan Karolil <[email protected]> * feat(annotation): add toast feedback to annotation templates (apache#18116) * feat(dashboard): add toast feedback to dashboard actions (apache#18114) * feat(explore): more toast feedback on user actions in Explore (apache#18108) * feat(explore): add toasts feedback when user copies chart url * Show toast message when updating chart properties * Change toast type to success when saving chart * Use success toast from props * Fix tests * Use withToasts instead of dispatch * Use PropertiesModalProps instead of any * Docs: fix typo (apache#18125) * fix: undefined error when adding extra sequential color scheme (apache#18152) * feat: allow assets to be managed externally (apache#18093) * feat: allow assets to be managed externally * Use server_default * chore: use pkg_resources for cleaner config (apache#18130) * refactor: Moves the Explore form_data endpoint (apache#18151) * refactor: Moves the Explore form_data endpoint * Removes unused imports * Fixes openapi schema error * Fixes typo * Renames and UPDATING.md Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]> * fix up links * Fix whitespace * Remove unwanted change * Add apache links Co-authored-by: hughhhh <[email protected]> Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Daniel W <[email protected]> Co-authored-by: Srini Kadamati <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]>

* setup docusaurus * rename * add introduction content * chore(docsV2): move content from docs to docsV2 (apache#17714) * add FAQs and contribution pages * chore: add api, security, and roadmap pages, include swaggerui in dependency for api page * chore: move api page header below imports * chore: change API page info alert to use built in Infima class instead of custom class Co-authored-by: Corbin Robb <[email protected]> * chore(docs-v2): moving more markdown content to new documentation site (apache#17736) * chore: move markdown content and images for docs installation directory to docs-v2 * chore: move docs miscellaneous directory content to docs-v2 * chore(docs-v2): move over connecting to databases content and rename some files to .mdx Co-authored-by: Corbin Robb <[email protected]> * Update styling and logo (apache#17990) * update styling * update colors * chore(docs-v2): remove blog and tutorial and update some styling (apache#17929) * add superset logo and favicon, change styles to better match current docs, add prettierrc * change file types to mdx * Add simple superset dark mode freindly logo * clean up default pages - blog and tutorial docs Co-authored-by: Corbin Robb <[email protected]> * Chore: moving charts and dashboard to docusaurus (apache#18036) * add contributing add creating charts and dashboards * delete extra images * update rat-excludes * Port homepage (apache#18115) * Port community page (apache#18128) * chore: add seo redirects for Docs v@ (apache#18092) * fix: handle null values in time-series table (apache#18039) * cleanup column_type_mappings (apache#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (apache#18037) * Update superset-e2e.yml (apache#18041) * Revert "Update superset-e2e.yml (apache#18041)" (apache#18051) This reverts commit b565273. * feat: Trino Authentications (apache#17593) * feat: support Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * docs: Trino Authentications Signed-off-by: Đặng Minh Dũng <[email protected]> * chore(supeset.utils.core): move all database utils to database utils module (apache#18058) * chore(plugin-chart-echarts): add types to controls (apache#18059) * fix(generator): more cleanup to plugin framework (apache#18027) * fix(generator): more cleanup to plugin framework * fix typo and package name * add docs * fix typo * Update superset-frontend/webpack.config.js Co-authored-by: Kamil Gabryjelski <[email protected]> * fix generator reference * add steps to tutorial and fix package version * refine docs/readme Co-authored-by: Kamil Gabryjelski <[email protected]> * feat(advanced analytics): support groupby in resample (apache#18045) * fix(dashboard): scope of nativefilter not update (apache#18048) * fix(generator): add lockfile and fix styling issues (apache#18073) * fix(generator): add lockfile and fix styling issues * fix margins and remove redundant scroll * update tutorial * refactor(sql_lab): SQL Lab Persistent Saved State (apache#17771) * a lot of console logs * testing * test * added saved_query to remoteId * created useEffect so that title properly changes in modal * Update superset-frontend/src/SqlLab/actions/sqlLab.js Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> * refactor(example_data): replace the way the birth_names data is loaded to DB (apache#18060) * refactor: replace the way the birth_names data is loaded to DB * fix failed unit test * fix failed unit test * fix failed tests * fix pass wrong flag of support datetime type * remove unused fixture * feat: add chart description in info tooltip (apache#17207) * feat: add chart list description * fix: text overflow * fix: text-overflow with line-height * Correction of proper names format in README (apache#18087) * chore: added SEO routes * fix can't use examples helpers on non app context based environment (apache#18086) * chore: split CLI into multiple files (apache#18082) * chore: split CLI into multiple files * Update tests * Who fixes the fixtures? * Add subcommands dynamically * Rebase * fix misspelling (apache#18097) * refactor: sqleditorleftbar to functional (apache#17807) * Working on converting sqleditorleftbar to functional component * Creating draft PR to address bug * Still working on solving re rendering bug * infinite rerender fix * Creating draft PR to address bug * Cleaning up in preparation for push * Made changes suggested by Elizabeth * Fixed issues as per Lindsey's comment Co-authored-by: Arash <[email protected]> * fix rat excludes and headers * fix(docs): fix path of image for "Create New Chart" (apache#18089) * Migrate Checkbox story to tsx - see apache#18100 (apache#18101) Looks good! * refactor: migrate RowCountLabel to TypeScript & added story (apache#18105) * enable superbook for explore component * migrate RowCountLabel to TypeScript * add storybook for RowCountLabel * fix: logging warning on dataframe (don't use python's warnings) (apache#18111) * fix: logging warning on dataframe (don't use python's warnings) * lint * update changelog and updating for 1.4.0 (apache#18083) * feat: Adds a key-value endpoint to store charts form data (apache#17882) * feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access * fix(explore): fix chart embed code modal glitch (apache#17843) * feat(plugin-chart-echarts): support non-timeseries x-axis (apache#17917) * feat(plugin-chart-echarts): support non-timeseries x-axis * fix tests * change formula return type from Date to number * add x_axis test coverage * rename func and improve coverage * add x-axis control to bar chart * remove redundant console.log * fix description * make x-axis control mandatory * 🙃 * fix x-axis formatter * fix showValues * fix implicit rDTTM_ALIAS references in postProcessing * replace TIME_COLUMN with DTTM_ALIAS * fix remaining implicit indexes * fix: Disable filtering on wide result sets (apache#18021) * fix: handle null values in time-series table (apache#18039) * cleanup column_type_mappings (apache#17569) Signed-off-by: Đặng Minh Dũng <[email protected]> * important change to MakeFile (apache#18037) * add missing is_timeseries to pivot op Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> * feat(country-map): added new countries in country-chart-map (apache#18081) * chore: migrating storybook jsx to typescript apache#18100 (apache#18133) * Migrating storybook jsx to typescript apache#18100 * Migrating storybook jsx to typescript Co-authored-by: Jayakrishnan Karolil <[email protected]> * feat(annotation): add toast feedback to annotation templates (apache#18116) * feat(dashboard): add toast feedback to dashboard actions (apache#18114) * feat(explore): more toast feedback on user actions in Explore (apache#18108) * feat(explore): add toasts feedback when user copies chart url * Show toast message when updating chart properties * Change toast type to success when saving chart * Use success toast from props * Fix tests * Use withToasts instead of dispatch * Use PropertiesModalProps instead of any * Docs: fix typo (apache#18125) * fix: undefined error when adding extra sequential color scheme (apache#18152) * feat: allow assets to be managed externally (apache#18093) * feat: allow assets to be managed externally * Use server_default * chore: use pkg_resources for cleaner config (apache#18130) * refactor: Moves the Explore form_data endpoint (apache#18151) * refactor: Moves the Explore form_data endpoint * Removes unused imports * Fixes openapi schema error * Fixes typo * Renames and UPDATING.md Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]> * Fix broken build * Revert unwanted change Co-authored-by: hughhhh <[email protected]> Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Corbin Robb <[email protected]> Co-authored-by: Daniel W <[email protected]> Co-authored-by: Srini Kadamati <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Đặng Minh Dũng <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: ofekisr <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Stephen Liu <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: Adam Dobrawy <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Emily Wu <[email protected]> Co-authored-by: Josue Lugaro <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Hammad-Raza <[email protected]> Co-authored-by: jayakrishnankk <[email protected]> Co-authored-by: Jayakrishnan Karolil <[email protected]> Co-authored-by: Farid Rener <[email protected]>