-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: null dates in table chart #17974
fix: null dates in table chart #17974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Codecov Report
@@ Coverage Diff @@
## master #17974 +/- ##
=======================================
Coverage 67.08% 67.08%
=======================================
Files 1611 1611
Lines 64919 64920 +1
Branches 6871 6872 +1
=======================================
+ Hits 43548 43551 +3
+ Misses 19504 19503 -1
+ Partials 1867 1866 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://54.187.69.126:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Currently, when a date is null and it's in a temporal column, it renders as
1970-01-01
instead ofN/A
. This PR fixes itBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Test dataset (generated in SQL Lab):
Table chart before fix:
Table chart after fix:
TESTING INSTRUCTIONS
CI, new unit test, create a dataset with a temporal column in dev, add at least one row with null, ensure it renders as N/A
ADDITIONAL INFORMATION
to: @ktmud @graceguo-supercat @michael-s-molina @rusackas