-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ExploreCtasResultsButton): convert to functional component #17939
refactor(ExploreCtasResultsButton): convert to functional component #17939
Conversation
chore: fix misspelling of button
/testenv up |
@AAfghahi Ephemeral environment spinning up at http://34.219.47.255:8080. Credentials are |
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #17939 +/- ##
==========================================
+ Coverage 66.34% 66.56% +0.21%
==========================================
Files 1569 1573 +4
Lines 61687 61799 +112
Branches 6241 6294 +53
==========================================
+ Hits 40927 41134 +207
+ Misses 19162 19013 -149
- Partials 1598 1652 +54
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6117cdb
to
d78d0dc
Compare
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsx
Outdated
Show resolved
Hide resolved
/testenv up |
@AAfghahi we can't test ctas on the ephemeral, can we? |
@eschutho Ephemeral environment spinning up at http://35.87.218.85:8080. Credentials are |
I don't think we can, but we also couldn't enable it with a SQLite example db. I can pull it down and test in postgres. |
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this, thank you!
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great @ChristopherCFleming! Just a few small nits.
/testenv up |
@eschutho Ephemeral environment spinning up at http://34.215.151.120:8080. Credentials are |
tested this locally to see that it works: Screen.Recording.2022-02-08.at.2.27.11.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you @ChristopherCFleming!
Ephemeral environment shutdown and build artifacts deleted. |
Thank you! Appreciate your time and guidance. |
SUMMARY
Updated from class component into functional component. Moved onClick below Visualize.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION