Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deck.gl): update view state on property changes (#17720) #17826

Merged
merged 2 commits into from
Feb 11, 2022
Merged

fix(deck.gl): update view state on property changes (#17720) #17826

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3d7fbc
Update viewstate on property changes
hbruch Dec 20, 2021
dbbfec7
Compare props via isEqual
hbruch Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions superset-frontend/plugins/legacy-preset-chart-deckgl/src/DeckGLContainer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
import { isEqual } from 'lodash';
import { StaticMap } from 'react-map-gl';
import DeckGL from 'deck.gl';
import { styled } from '@superset-ui/core';
Expand Down Expand Up @@ -63,6 +64,12 @@ export class DeckGLContainer extends React.Component {
};
}

UNSAFE_componentWillReceiveProps(nextProps) {
if (!isEqual(nextProps.viewport, this.props.viewport)) {
this.setState({ viewState: nextProps.viewport });
}
}

componentWillUnmount() {
clearInterval(this.state.timer);
}
Expand Down