Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(contributing): update contributing section on docs page to match CONTRIBUTING.md #17718

Merged
merged 9 commits into from
Jan 10, 2022
Merged

docs(contributing): update contributing section on docs page to match CONTRIBUTING.md #17718

merged 9 commits into from
Jan 10, 2022

Conversation

riahk
Copy link
Contributor

@riahk riahk commented Dec 10, 2021

SUMMARY

  • Turn Contributing menu link into a collapsible section
  • Migrate sections from CONTRIBUTING.md to docs page
  • Add Running Frontend Assets Locally page to Installation and Configuration section

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-12-10 at 3 05 18 PM

Screen Shot 2021-12-10 at 3 05 31 PM

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@riahk riahk force-pushed the moriah/contributing-docs branch from 79d6854 to 861f66b Compare December 14, 2021 20:47
@riahk riahk force-pushed the moriah/contributing-docs branch from 2add3d3 to f9f5272 Compare December 17, 2021 18:40
villebro
villebro approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome work! LGTM

@srinify
Copy link
Contributor

srinify commented Jan 10, 2022

Also reviewed and approved. Good stuff!

@srinify srinify merged commit 7329e3c into apache:master Jan 10, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@riahk @shcoderAlex
docs(contributing): update contributing section on docs page to match…
d330426 
… CONTRIBUTING.md (apache#17718)

* add contributing section with CONTRIBUTING.MD sections to docs page

* rm extraneous links

* add chart param reference, update section titles

* useful links

* test openapi

* revert test code

* bump swagger-react-ui version

* update package lock

* fix lock
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@riahk @bwang221
docs(contributing): update contributing section on docs page to match…
51f8bb8 
… CONTRIBUTING.md (apache#17718)

* add contributing section with CONTRIBUTING.MD sections to docs page

* rm extraneous links

* add chart param reference, update section titles

* useful links

* test openapi

* revert test code

* bump swagger-react-ui version

* update package lock

* fix lock
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@srinify srinify srinify approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XXL 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riahk @srinify @villebro @mistercrunch