chore: migrate AnchorLink component from jsx to tsx #17647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etr2460 Ptal, thx! |
Damans227
commented
Dec 4, 2021
| if (inFocus) { | ||
| this.scrollToView(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Resources referred to replace the UNSAFE_componentWillReceiveProps:
Damans227
commented
Dec 4, 2021
| if (inFocus) { | ||
| scrollToView(); | ||
| } | ||
| }, [inFocus]) |
There was a problem hiding this comment.
Replaces UNSAFE_componentWillReceiveProps method
Damans227
commented
Dec 4, 2021
Damans227
force-pushed
the
enhancement/migrate-jsx-to-tsx_7
branch
from
dce84e3
to
97bb8e4
Compare
etr2460
reviewed
Dec 8, 2021
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
PR for migrating
AnchorLinkreact component from JSX to TSXBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION