chore: Added unit test to query context change #17624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
force-pushed
the
ch31968tests
branch
from
8d5809e to
52b2db8
Compare
betodealmeida
requested changes
Dec 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #17624 +/- ##
=======================================
Coverage 68.36% 68.36%
=======================================
Files 1601 1601
Lines 65260 65263 +3
Branches 6963 6963
=======================================
+ Hits 44616 44619 +3
Misses 18754 18754
Partials 1890 1890
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Dec 2, 2021
| @patch("superset.security.manager.g") | ||
| @pytest.mark.usefixtures("load_energy_table_with_slice") | ||
| def test_export_chart_with_query_context(self, mock_g): | ||
| """Test that charts that have a query_context are imported correctly""" |
There was a problem hiding this comment.
Suggested change
| """Test that charts that have a query_context are imported correctly""" | |
| """Test that charts that have a query_context are exported correctly""" |
AAfghahi
force-pushed
the
ch31968tests
branch
from
52b2db8 to
2ea8580
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is adding a unit test to a previous PR (#17600). I added a query_context to one of the current fixtures and exported it, making sure that there was no query context.
For importing charts, the example that we are currently using has a query context already included, and the importing does not transfer it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION