Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legacy-preset-chart-nvd3): add richtooltip in nvd3 bar chart #17615

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Dec 1, 2021

SUMMARY

This is an enhancement of the rich tooltip about nvd3 bar chart, since we haven't merged into categorical bar echart yet, so
let get it here for nvd3 chart

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

time series bar chart

image

bar chart

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [Bar Chart] Rich tooltip does not work #15162
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #17615 (357a18f) into master (78c5d9a) will decrease coverage by 0.18%.
The diff coverage is 25.00%.

❗ Current head 357a18f differs from pull request most recent head 98f3295. Consider uploading reports for the commit 98f3295 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17615      +/-   ##
==========================================
- Coverage   68.55%   68.36%   -0.19%     
==========================================
  Files        1601     1601              
  Lines       65258    65263       +5     
  Branches     6963     6963              
==========================================
- Hits        44736    44616     -120     
- Misses      18632    18757     +125     
  Partials     1890     1890              
Flag Coverage Δ
hive ?
javascript 57.06% <0.00%> (-0.01%) ⬇️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gacy-preset-chart-nvd3/src/DistBar/controlPanel.ts 38.46% <ø> (ø)
...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <0.00%> (ø)
superset/dashboards/api.py 91.86% <66.66%> (-0.29%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-6.89%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-1.58%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.15% <0.00%> (-0.39%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c5d9a...98f3295. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Dec 1, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

@rusackas Ephemeral environment spinning up at http://35.87.136.23:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit 72f3215 into apache:master Dec 2, 2021
@rusackas
Copy link
Member

rusackas commented Dec 2, 2021

Thanks for the improvement!!!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants