Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated selects and deps #17522

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Nov 23, 2021

SUMMARY

It appears we are no longer using the AsyncSelect, PaginatedSelect and WindowedAsyncSelect components, hence we can remove them and associated dependencies.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro force-pushed the villebro/remove-async-select branch from 6171992 to a8a270c Compare November 23, 2021 09:28
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #17522 (b82af0d) into master (bc855f4) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head b82af0d differs from pull request most recent head a8a270c. Consider uploading reports for the commit a8a270c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17522      +/-   ##
==========================================
- Coverage   76.92%   76.78%   -0.14%     
==========================================
  Files        1048     1048              
  Lines       56514    56509       -5     
  Branches     7805     7805              
==========================================
- Hits        43474    43392      -82     
- Misses      12786    12863      +77     
  Partials      254      254              
Flag Coverage Δ
hive ?
javascript 71.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/components/Select/DeprecatedSelect.tsx 63.63% <ø> (-1.07%) ⬇️
...end/src/components/Select/WindowedSelect/index.tsx 100.00% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-0.84%) ⬇️
superset/db_engine_specs/base.py 88.20% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 86.79% <0.00%> (-0.23%) ⬇️
superset/utils/core.py 89.64% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc855f4...a8a270c. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 18c7aec into apache:master Nov 23, 2021
@villebro villebro deleted the villebro/remove-async-select branch November 23, 2021 10:41
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants