chore: Add test for flask wtf csrf exempt config #17468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
force-pushed
the
erik-ritter--add-csrf-exempt-test
branch
3 times, most recently
from
19b2a07
to
1e8dc34
Compare
|
Any ideas why tests are failing here? My new test is working at least :/ |
you should debug it, contact me if you need help |
etr2460
force-pushed
the
erik-ritter--add-csrf-exempt-test
branch
from
3147c02
to
7c50790
Compare
ofekisr
reviewed
Nov 18, 2021
| all_view_functions = { | ||
| f"{view.__module__}.{view.__name__}" for view in app.view_functions.values() | ||
| } | ||
| for exempt_api in app.config["WTF_CSRF_EXEMPT_LIST"]: |
There was a problem hiding this comment.
Rare use case, but you should check against the default config (superset.config) and not from the test config even if the test config does not contain "WTF_CSRF_EXEMPT_LIST" key
etr2460
force-pushed
the
erik-ritter--add-csrf-exempt-test
branch
from
7c50790
to
a034bc4
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow up from #17429 to add a test to ensure this doesn't break again
TESTING INSTRUCTIONS
CI, ensure that when i add a view that doesn't exist onto the exempt list the test fails
ADDITIONAL INFORMATION
to: @john-bodley @ofekisr @villebro