-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate DragHandle component from jsx to tsx #17326
chore: migrate DragHandle component from jsx to tsx #17326
Conversation
@etr2460 Ptal, thx! |
Codecov Report
@@ Coverage Diff @@
## master #17326 +/- ##
==========================================
+ Coverage 76.87% 76.96% +0.08%
==========================================
Files 1037 1037
Lines 55647 55654 +7
Branches 7608 7618 +10
==========================================
+ Hits 42779 42833 +54
+ Misses 12618 12566 -52
- Partials 250 255 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! if you wanted to make this as functional component too, i wouldn't complain. but that doesn't need to be addressed
c70478a
to
fd1c2fe
Compare
Sure, will give it a shot. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution!
Thanks for this improvement @Damans227 ! |
SUMMARY
PR for migrating
DragHandle
functional react component from JSX to TSXBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION