-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Fix issue #17144 - Resetting native filter form does not clear the values. #17217
fix(dashboard): Fix issue #17144 - Resetting native filter form does not clear the values. #17217
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17217 +/- ##
=======================================
Coverage 76.86% 76.87%
=======================================
Files 1039 1038 -1
Lines 55608 55618 +10
Branches 7580 7585 +5
=======================================
+ Hits 42744 42756 +12
+ Misses 12614 12612 -2
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true |
@geido Ephemeral environment spinning up at http://54.185.8.203:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix! i'll merge now
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Fix issue #17144
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION