-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(engine): Translate fractional time grains—requires @superset-ui bump #17078
chore(engine): Translate fractional time grains—requires @superset-ui bump #17078
Conversation
7f23f15
to
c288668
Compare
c288668
to
14f2284
Compare
14f2284
to
42fb888
Compare
Codecov Report
@@ Coverage Diff @@
## master #17078 +/- ##
==========================================
- Coverage 76.88% 76.66% -0.22%
==========================================
Files 1031 1031
Lines 55197 55197
Branches 7506 7506
==========================================
- Hits 42436 42317 -119
- Misses 12509 12628 +119
Partials 252 252
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. From what I remember when I added the time grains in ISO format I was just looking for a standard format to represent intervals, I don't think there was any reason to choose 0.25Y
instead of 3M
. And I agree the latter is more clear.
9b134d0
to
7ff7fc1
Compare
7ff7fc1
to
6ccaa17
Compare
@john-bodley do we need an accompanying migration updating saved charts? We're getting an error when loading the sales dashboard "No grain spec for P0.25Y for database postgresql". |
… bump (apache#17078) * chore(engine): Translate fractional time grains * Bump @superset-ui Co-authored-by: John Bodley <[email protected]>
… bump (#17078) * chore(engine): Translate fractional time grains * Bump @superset-ui Co-authored-by: John Bodley <[email protected]>
SUMMARY
In #17050 @villebro and myself were discussing why fractional ISO8601 periods were being used to represent either 30 minutes (
PT0.5H
) or the quarter (P0.25Y
) rather thanPT30M
andP3M
respectively.This PR updates the time grains to reflect the preferred format. Note the
@superset-ui
package needed to be bumped to0.18.12
as part of the change given the time grains are defined in both repos.TESTING INSTRUCTIONS
Tested locally. Additionally grepped the coded base by running
git grep "PT0.5H" and
git grep "P0.25Y"`.ADDITIONAL INFORMATION