-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Update text for SLL Tooltip #16993
style: Update text for SLL Tooltip #16993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Codecov Report
@@ Coverage Diff @@
## master #16993 +/- ##
==========================================
- Coverage 76.90% 76.84% -0.07%
==========================================
Files 1024 1026 +2
Lines 54931 54915 -16
Branches 7486 7478 -8
==========================================
- Hits 42246 42197 -49
- Misses 12437 12467 +30
- Partials 248 251 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@gabester78 Thanks for the contribution! I believe the text might be misleading. Our documentation does not always have a reference to the SSL settings, see MySQL for instance. In other cases, such as Presto, you would just be redirected to the database list. I would rather change the text with something even more generic, like: Enable SSL for increased security. Refer to the official documentation for more information. |
Hey Geido! This is the text that Sophie requested, but you bring up a good point if we don't have documentation for all database SSL settings. I think this would be better in that case, but I'd like to check and make sure it's alright to change - what do you think @yousoph ? |
Thanks for the suggestion @geido, that's a good point. The text you suggested makes sense to me! |
Changed tooltip text per Geido's suggestion. I was having issues with the setup.cfg file being changed when trying to push up changes so I made the change directly in Github. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Updated tooltip text to match Trello task. * Added graphlib * Update DatabaseConnectionForm.tsx Co-authored-by: Gabriel Romero <[email protected]>
* Updated tooltip text to match Trello task. * Added graphlib * Update DatabaseConnectionForm.tsx Co-authored-by: Gabriel Romero <[email protected]>
SUMMARY
Changed the SSL tooltip text to a general hint for all users.
https://trello.com/c/B4i4wtpq/29-update-ssl-tooltip-text
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION