Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changes the main menu order as defined in SIP-34 #15929

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jul 28, 2021

SUMMARY

This PR is a follow-up of #15915 where we discussed the possibility of ordering the main menu items according to user workflows or usage. We decided to change the main menu order as defined in SIP-34.

The order defined was Dashboards -> Charts -> SQL Lab -> Data as you can see in the following screenshot from SIP-34:

72392712-8a10f800-36e5-11ea-95a1-3d9c1b60719f

Thanks @junlincc @ktmud @graceguo-supercat @john-bodley @srinify for the valuable discussion.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

127211943-d3dfe888-f62e-4fe4-896c-6e035e2aac06

Screen Shot 2021-07-28 at 2 37 22 PM

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #15929 (384e791) into master (32d2aa0) will decrease coverage by 0.08%.
The diff coverage is 88.57%.

❗ Current head 384e791 differs from pull request most recent head a5f9678. Consider uploading reports for the commit a5f9678 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15929      +/-   ##
==========================================
- Coverage   77.05%   76.97%   -0.09%     
==========================================
  Files         988      988              
  Lines       52180    52195      +15     
  Branches     7095     7095              
==========================================
- Hits        40209    40175      -34     
- Misses      11746    11795      +49     
  Partials      225      225              
Flag Coverage Δ
hive 81.27% <100.00%> (+0.01%) ⬆️
mysql 81.48% <100.00%> (-0.04%) ⬇️
postgres 81.55% <100.00%> (+0.05%) ⬆️
presto ?
python 81.89% <100.00%> (-0.18%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/CronPicker/CronPicker.tsx 91.66% <ø> (ø)
superset-frontend/src/views/CRUD/alert/types.ts 100.00% <ø> (ø)
superset/annotation_layers/annotations/api.py 84.96% <ø> (ø)
superset/reports/api.py 87.78% <ø> (ø)
superset/reports/logs/api.py 94.11% <ø> (ø)
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 61.70% <66.66%> (ø)
superset/charts/api.py 85.48% <100.00%> (ø)
superset/dashboards/api.py 92.95% <100.00%> (ø)
superset/initialization/__init__.py 87.91% <100.00%> (ø)
superset/models/reports.py 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d2aa0...a5f9678. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 7b0acc4 into apache:master Jul 28, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants