feat: add possibility to specify Service Account name for the Deployment in the Helm chart #15340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@craig-rueda could you please review? |
mvoitko
changed the title
craig-rueda
reviewed
Jun 24, 2021
| @@ -53,6 +53,7 @@ spec: | |||
| app: {{ template "superset.name" . }}-worker | |||
| release: {{ .Release.Name }} | |||
| spec: | |||
| serviceAccountName: {{ .Values.serviceAccountName }} | |||
There was a problem hiding this comment.
can you wrap this with an 'if' that checks whether the SA name is set, and then leave the value empty in values.yaml?
There was a problem hiding this comment.
What do you mean by SA name is set? I could check if the value is empty in values then I could skip this. Do you mean smth like:
{{ if .Values.serviceAccountName }}
serviceAccountName: {{ .Values.serviceAccountName }}
{{ end }}
But i would prefer to eliminate "if" statements to make code more clear
There was a problem hiding this comment.
Yep, like that. Allows the field to remain unset if unused
There was a problem hiding this comment.
@craig-rueda please approve
mvoitko
force-pushed
the
feature/add-service-account-configuration-to-helm-deployment
branch
from
3f81132
to
a2c66ec
Compare
craig-rueda
reviewed
Jun 25, 2021
helm/superset/Chart.yaml
Outdated
| @@ -22,7 +22,7 @@ maintainers: | |||
| - name: craig-rueda | |||
| email: [email protected] | |||
| url: https://github.com/craig-rueda | |||
| version: 0.1.6 | |||
| version: 0.2.6 | |||
There was a problem hiding this comment.
Pls set the version to 0.2.0
mvoitko
force-pushed
the
feature/add-service-account-configuration-to-helm-deployment
branch
from
a2c66ec
to
f2fa729
Compare
craig-rueda
approved these changes
Jun 26, 2021
mvoitko
deleted the
feature/add-service-account-configuration-to-helm-deployment
branch
|
It seems to me that |
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
… the Helm chart (apache#15340) Co-authored-by: Maksym V <[email protected]>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
… the Helm chart (apache#15340) Co-authored-by: Maksym V <[email protected]>
9 tasks
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
… the Helm chart (apache#15340) Co-authored-by: Maksym V <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We need to be able specify Service Account name differing from the default which will have permissions needed for the Superset
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
helm install superset .ADDITIONAL INFORMATION