Moved sqllab tests from core_tests to sqllab_tests #1502
Merged
+179
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
reviewed
Nov 1, 2016
| @@ -176,3 +176,14 @@ def revoke_public_access(self, table_name): | |||
| if (perm.permission.name == 'datasource_access' and | |||
| perm.view_menu and table_name in perm.view_menu.name): | |||
| appbuilder.sm.del_permission_role(public_role, perm) | |||
|
|
|||
| def run_sql(self, sql, user_name, client_id): | |||
There was a problem hiding this comment.
make user_name optional and if none run as admin
bkyryliuk
reviewed
Nov 1, 2016
| self.run_sql("SELECT * FROM ab_permission", 'gamma', client_id='client_id_2') | ||
|
|
||
| def tearDown(self): | ||
| pass |
There was a problem hiding this comment.
db.session.query(models.Query).delete()
do the same in core tests
bkyryliuk
reviewed
Nov 1, 2016
|
|
||
| def test_sql_json(self): | ||
| data = self.run_sql('SELECT * FROM ab_user', 'admin', "1") | ||
| assert len(data['data']) > 0 |
There was a problem hiding this comment.
while you are here, could you please refactor asserts into assertEquals, assertLess, etc ?
|
minor comments, looks good overall ! |
vera-liu
force-pushed
the
vliu_move_sqllab_tests
branch
from
ae92b37
to
6f9477d
Compare
vera-liu
force-pushed
the
vliu_move_sqllab_tests
branch
from
ed22cdb
to
b34cd22
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Done:
needs-review @mistercrunch @bkyryliuk