feat(db-connection-ui): Show Preferred DBs #14951

hughhhh · 2021-06-02T17:56:00Z

SUMMARY

Added starter Step 1 for preferred dbs render. User will now see the preferred DBs set in the superset_config file, and will be in a top section to make it easier for people to get to the connection page (step 2)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

https://www.loom.com/share/ab848326e2884b19bd248303e50f4da0

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

* poc picker for db selection * working select * setup is loading for available dbs and step1 view * fix on close * update on fetch * remove unneeded code * add some styls

…-io/superset into pexdax/db-connection-ui-show-preferred

codecov · 2021-06-02T18:56:19Z

Codecov Report

Merging #14951 (c21987f) into pexdax/db-connection-ui (b8e6687) will increase coverage by 0.11%.
The diff coverage is 90.62%.

❗ Current head c21987f differs from pull request most recent head 4aa2428. Consider uploading reports for the commit 4aa2428 to get more accurate results

@@                     Coverage Diff                     @@
##           pexdax/db-connection-ui   #14951      +/-   ##
===========================================================
+ Coverage                    77.52%   77.63%   +0.11%     
===========================================================
  Files                          965      964       -1     
  Lines                        49530    49361     -169     
  Branches                      6272     6229      -43     
===========================================================
- Hits                         38398    38322      -76     
+ Misses                       10929    10840      -89     
+ Partials                       203      199       -4

Flag	Coverage Δ
hive	`81.35% <ø> (-0.01%)`	⬇️
mysql	`81.63% <ø> (-0.01%)`	⬇️
postgres	`81.66% <ø> (-0.01%)`	⬇️
presto	`81.34% <ø> (-0.01%)`	⬇️
python	`82.18% <ø> (-0.01%)`	⬇️
sqlite	`81.27% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...erset-frontend/src/components/IconButton/index.tsx	`100.00% <ø> (ø)`
.../database/DatabaseModal/DatabaseConnectionForm.tsx	`54.54% <ø> (+8.83%)`	⬆️
superset/config.py	`91.09% <ø> (ø)`
...c/views/CRUD/data/database/DatabaseModal/index.tsx	`76.12% <89.65%> (+16.36%)`	⬆️
...c/views/CRUD/data/database/DatabaseModal/styles.ts	`97.36% <100.00%> (+8.03%)`	⬆️
...d/src/dashboard/components/gridComponents/Tabs.jsx	`76.31% <0.00%> (-11.07%)`	⬇️
...nd/src/dashboard/containers/DashboardComponent.jsx	`84.84% <0.00%> (-7.46%)`	⬇️
...nd/src/dashboard/components/nativeFilters/utils.ts	`81.63% <0.00%> (-4.62%)`	⬇️
...et-frontend/src/dashboard/actions/nativeFilters.ts	`76.59% <0.00%> (-4.26%)`	⬇️
...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx	`84.61% <0.00%> (-2.06%)`	⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e6687...4aa2428. Read the comment docs.

hughhhh · 2021-06-03T17:32:03Z

superset/config.py

@@ -1075,10 +1075,10 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC(
 # use the "engine_name" attribute of the corresponding DB engine spec
 # in `superset/db_engine_specs/`.
 PREFERRED_DATABASES: List[str] = [


will remove before merging

hughhhh · 2021-06-03T17:33:54Z

/testenv up

github-actions · 2021-06-03T17:52:44Z

@hughhhh Container image not yet published for this PR. Please try again when build is complete.

github-actions · 2021-06-03T17:52:45Z

@hughhhh Ephemeral environment creation failed. Please check the Actions logs for details.

AAfghahi · 2021-06-03T18:38:34Z

superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts

@@ -340,5 +355,30 @@ export const EditHeaderSubtitle = styled.div`
 `;

 export const SelectDatabaseStyles = styled.div`
-  margin: ${({ theme }) => theme.gridUnit * 4}px;
+  margin: 0 16px;


use gridUnit

eschutho · 2021-06-03T19:52:32Z

superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

@@ -299,6 +301,73 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
    }
  };

+  const setDatabaseModel = option => {


can the param be "engine" if it's just a string? Maybe a type on that would help, too.

eschutho · 2021-06-03T19:52:55Z

superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

+        engine: option,
+      },
+    });
+    console.log('isDynamic', isDynamic);


eschutho · 2021-06-03T19:55:30Z

superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

+    console.log('isDynamic', isDynamic);
+  };
+
+  const renderAvailableSelector = () => (


can we move step one into a separate file?

eschutho · 2021-06-03T19:56:43Z

superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

+
+  const renderModalFooter = () =>
+    db // if db show back + connect
+      ? [


db && (
<>

would that work instead?

eschutho · 2021-06-03T19:58:09Z

This is looking good @hughhhh!

lyndsiWilliams and others added 14 commits June 1, 2021 08:33

Creating IconButton

6d0c45f

Changed naming: logo is now icon

b0cdaba

Hard-coded inset values for ellipses

8d96434

Removed default SVG

3eea36d

Fixed test

b0ab2da

Removed logo from test

c8b148e

split db modal file

e7f0dbb

hook up available databases

b57d090

use new validation component

271c6e9

feat(db-connection-ui): Allow users to pick engine (#14884)

ef63e3c

* poc picker for db selection * working select * setup is loading for available dbs and step1 view * fix on close * update on fetch * remove unneeded code * add some styls

Merge branch 'lyndsi/create-icon-button' of https://github.com/preset…

8907bc1

…-io/superset into pexdax/db-connection-ui-show-preferred

saving for now

96a87d8

update styles

717c9ab

save

e299bfa

pull-request-size bot added the size/XL label Jun 2, 2021

hughhhh added 2 commits June 2, 2021 14:38

create 1 function for setting the DB

8cfa0d8

add function to preferred section

7c610d5

hughhhh added 7 commits June 2, 2021 15:07

small refactor and added styling

dcf8144

add new footer buttons

ef23e53

add finsh buttong

2602827

refactor db modal render

530150e

fix comments issue

508a6b9

add header

607e01a

add bottom footer to sqlalchemy form

b343ca4

hughhhh force-pushed the pexdax/db-connection-ui branch from a380629 to d5c5167 Compare June 3, 2021 16:45

hughhhh added 2 commits June 3, 2021 13:17

add back headers

0df0cab

fix merge conflicts

0d3c31d

pull-request-size bot added size/L and removed size/XL labels Jun 3, 2021

hughhhh requested a review from betodealmeida June 3, 2021 17:31

hughhhh commented Jun 3, 2021

View reviewed changes

add step

c21987f

hughhhh changed the title ~~Pexdax/db connection UI show preferred~~ feat(db-connection-ui): Show Preferred DBs Jun 3, 2021

AAfghahi reviewed Jun 3, 2021

View reviewed changes

eschutho reviewed Jun 3, 2021

View reviewed changes

hughhhh added 3 commits June 3, 2021 23:48

address comments

9d2b36e

fix merge conflicts

6c9fc9c

oops

4aa2428

hughhhh merged commit d05814c into pexdax/db-connection-ui Jun 4, 2021

rusackas deleted the pexdax/db-connection-ui-show-preferred branch January 30, 2023 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(db-connection-ui): Show Preferred DBs #14951

feat(db-connection-ui): Show Preferred DBs #14951

hughhhh commented Jun 2, 2021 •

edited

Loading

codecov bot commented Jun 2, 2021 •

edited

Loading

hughhhh Jun 3, 2021

hughhhh commented Jun 3, 2021

github-actions bot commented Jun 3, 2021

github-actions bot commented Jun 3, 2021

AAfghahi Jun 3, 2021

eschutho Jun 3, 2021

eschutho Jun 3, 2021

eschutho Jun 3, 2021

eschutho Jun 3, 2021

eschutho commented Jun 3, 2021

feat(db-connection-ui): Show Preferred DBs #14951

feat(db-connection-ui): Show Preferred DBs #14951

Conversation

hughhhh commented Jun 2, 2021 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Jun 2, 2021 • edited Loading

Codecov Report

hughhhh Jun 3, 2021

Choose a reason for hiding this comment

hughhhh commented Jun 3, 2021

github-actions bot commented Jun 3, 2021

github-actions bot commented Jun 3, 2021

AAfghahi Jun 3, 2021

Choose a reason for hiding this comment

eschutho Jun 3, 2021

Choose a reason for hiding this comment

eschutho Jun 3, 2021

Choose a reason for hiding this comment

eschutho Jun 3, 2021

Choose a reason for hiding this comment

eschutho Jun 3, 2021

Choose a reason for hiding this comment

eschutho commented Jun 3, 2021

hughhhh commented Jun 2, 2021 •

edited

Loading

codecov bot commented Jun 2, 2021 •

edited

Loading