chore: Consolidating form experience (Bootstrap to AntD) - iteration 4

[michael-s-molina]

SUMMARY

Migrates Form components from Bootstrap to AntD (iteration 4).

See: #10254

@rusackas @junlincc @pkdotson

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

1 - Navigate to the following areas:

• Explore > Add filter > Custom SQL
• Datasets -> Edit Dataset
• Charts -> Edit Chart
• Explore -> Change Dataset

2 - Check that the layouts and functionality are working

ADDITIONAL INFORMATION

• [] Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #14546 (094e813) into master (6d786d4) will decrease coverage by 0.09%.
The diff coverage is 71.15%.

❗ Current head 094e813 differs from pull request most recent head 1084379. Consider uploading reports for the commit 1084379 to get more accurate results

@@            Coverage Diff             @@
##           master   #14546      +/-   ##
==========================================
- Coverage   77.40%   77.31%   -0.10%     
==========================================
  Files         958      958              
  Lines       48329    48318      -11     
  Branches     5679     5675       -4     
==========================================
- Hits        37410    37357      -53     
- Misses      10719    10761      +42     
  Partials      200      200              

Flag	Coverage Δ
javascript	72.45% <71.15%> (-0.02%)	⬇️
presto	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/CRUD/Fieldset.jsx	85.71% <ø> (ø)
...trol/AdhocFilterEditPopoverSqlTabContent/index.jsx	61.29% <0.00%> (-2.05%)	⬇️
.../src/explore/components/controls/HiddenControl.jsx	57.14% <0.00%> (ø)
...rc/explore/components/controls/TextAreaControl.jsx	83.33% <ø> (ø)
...d/src/explore/components/PropertiesModal/index.tsx	84.28% <33.33%> (+2.09%)	⬆️
...l/AdhocFilterEditPopoverSimpleTabContent/index.jsx	77.63% <65.00%> (+0.14%)	⬆️
superset-frontend/src/CRUD/Field.jsx	80.00% <83.33%> (-3.34%)	⬇️
...-frontend/src/datasource/ChangeDatasourceModal.tsx	87.01% <88.88%> (+1.64%)	⬆️
...rset-frontend/src/components/DeleteModal/index.tsx	100.00% <100.00%> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx	66.38% <100.00%> (ø)
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d786d4...1084379. Read the comment docs.

[rusackas]

/testenv up

[github-actions]

@rusackas Ephemeral environment spinning up at http://52.88.132.72:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[junlincc]

thanks for the PR and enhancing the product experience! for QA purpose, could we list ALL areas that needs to be tested in the description? thanks

[michael-s-molina]

thanks for the PR and enhancing the product experience! for QA purpose, could we list ALL areas that needs to be tested in the description? thanks

Done 😉

TEST PLAN
1 - Navigate to the following areas:

Explore > Add filter > Custom SQL
Datasets -> Edit Dataset
Charts -> Edit Chart
Explore -> Change Dataset

2 - Check that the layouts and functionality are working

[junlincc]

Does Metric use the same form or is it not related ? It doesn't look right.

[michael-s-molina]

Does Metric use the same form or is it not related ? It doesn't look right.

@junlincc This component was not touched by this PR. I can also confirm that your reported problem is also happening on master so it's probably another issue.

[junlincc]

you are right, it's also happening on master. i'm surprised that Metrics and Filter don't share the same component. otherwise lgtm, thanks again! 🟢

[rusackas]

Code LGTM! Die, react-bootstrap, die! :)

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.