Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(native-filters): Update filter saving #14370

Merged
merged 9 commits into from
Apr 27, 2021
Merged

fix(native-filters): Update filter saving #14370

merged 9 commits into from
Apr 27, 2021

Conversation

simcha90
Copy link
Contributor

SUMMARY

This PR fix reloading charts after saving filters config modal.

  1. Clear dataMask on saving filters
  2. Getting back removed cross filters after getting filters config

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

villebro
villebro reviewed Apr 27, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typing comment

superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts Outdated
dataMask: DataMaskStateWithId,
filterBy: string,
prop?: string,
) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we add the return type here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #14370 (38ddceb) into master (d0be1ff) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 38ddceb differs from pull request most recent head 39e6a46. Consider uploading reports for the commit 39e6a46 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14370      +/-   ##
==========================================
- Coverage   76.90%   76.88%   -0.02%     
==========================================
  Files         954      954              
  Lines       48140    48158      +18     
  Branches     5986     5991       +5     
==========================================
+ Hits        37020    37025       +5     
- Misses      10923    10936      +13     
  Partials      197      197
Flag Coverage Δ
javascript 71.99% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/dashboard/containers/Dashboard.ts 0.00% <0.00%> (ø)
superset-frontend/src/dataMask/types.ts 100.00% <ø> (ø)
...nd/src/dashboard/util/activeAllDashboardFilters.ts 92.85% <50.00%> (-7.15%) ⬇️
superset-frontend/src/dataMask/reducer.ts 91.30% <60.00%> (-8.70%) ⬇️
...mponents/nativeFilters/FiltersConfigModal/utils.ts 68.42% <100.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0be1ff...39e6a46. Read the comment docs.

villebro
villebro approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works like a charm!

@villebro villebro merged commit 03e4a5b into apache:master Apr 27, 2021
@junlincc junlincc added dashboard:native-filters Related to the native filters of the Dashboard release:note test:case labels Apr 27, 2021
amitmiran137 pushed a commit that referenced this pull request Apr 28, 2021
@simcha90
fix(native-filters): Update filter saving (#14370)
6f1367d 
* fix:fix get permission function

* fix: not reload charts after save filters

* fix: not reload charts after save filters

* fix: temp commit type

* lint: add typing

(cherry picked from commit 03e4a5b)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@simcha90
fix(native-filters): Update filter saving (apache#14370)
c8c0557 
* fix:fix get permission function

* fix: not reload charts after save filters

* fix: not reload charts after save filters

* fix: temp commit type

* lint: add typing
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard release:note size/M test:case v1.2 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simcha90 @villebro @mistercrunch @amitmiran137 @junlincc