Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emotion): add separate namespace for menu app #14362

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

nytai
Copy link
Member

@nytai nytai commented Apr 26, 2021

SUMMARY

Adds emotion cache to the menu "app" so that styles do not collide with other other apps. The cache allows specifying a namespace for the emotion styles that is seperate from the default namespace, used by other "apps" on the same page.

More info on the issue here: emotion-js/emotion#2210

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
Screen Shot 2021-04-26 at 6 02 15 PM
after:
Screen Shot 2021-04-26 at 6 03 00 PM

TEST PLAN

  • run npm run build
  • see proper menu styling on the sqllab/dashboard/explore pages.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai marked this pull request as ready for review April 27, 2021 01:03
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #14362 (f3a497d) into master (8767798) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14362      +/-   ##
==========================================
- Coverage   77.14%   77.13%   -0.01%     
==========================================
  Files         954      954              
  Lines       48148    48148              
  Branches     5987     5986       -1     
==========================================
- Hits        37143    37140       -3     
- Misses      10808    10811       +3     
  Partials      197      197              
Flag Coverage Δ
javascript 72.01% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/menu.tsx 0.00% <0.00%> (ø)
...et-frontend/src/dashboard/components/SaveModal.tsx 45.45% <0.00%> (-1.72%) ⬇️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 54.62% <0.00%> (ø)
...src/explore/components/controls/VizTypeControl.jsx 81.48% <0.00%> (+1.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8767798...f3a497d. Read the comment docs.

@nytai nytai merged commit 86d2a61 into apache:master Apr 27, 2021
@nytai nytai deleted the tai/fix-multi-emotion branch April 27, 2021 21:54
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants