Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Bootstrap to AntD - Form - iteration 1 #14106

Merged
merged 1 commit into from
Apr 26, 2021
Merged

refactor: Bootstrap to AntD - Form - iteration 1 #14106

merged 1 commit into from
Apr 26, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Migrates Form components from Bootstrap to AntD (iteration 1)

See: #10254

@rusackas @junlincc @pkdotson

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-04-13 at 1 30 36 PM

Screen Shot 2021-04-13 at 1 30 36 PM

Screen Shot 2021-04-13 at 1 35 08 PM

Screen Shot 2021-04-13 at 1 35 29 PM

Screen Shot 2021-04-13 at 3 21 26 PM

Screen Shot 2021-04-13 at 3 21 26 PM

TEST PLAN

1 - Access the touched components
2 - Check that the layouts and functionality are working

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 13, 2021 •
edited
Loading

Codecov Report

Merging #14106 (a1142d7) into master (7ff35df) will decrease coverage by 0.16%.
The diff coverage is 55.55%.

❗ Current head a1142d7 differs from pull request most recent head 0ce5f5b. Consider uploading reports for the commit 0ce5f5b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14106      +/-   ##
==========================================
- Coverage   77.18%   77.01%   -0.17%     
==========================================
  Files         954      954              
  Lines       48134    48068      -66     
  Branches     5985     5972      -13     
==========================================
- Hits        37151    37021     -130     
- Misses      10786    10850      +64     
  Partials      197      197
Flag Coverage Δ
javascript 72.09% <55.55%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/explore/components/controls/VizTypeControl.jsx 82.75% <0.00%> (+3.09%) ⬆️
...et-frontend/src/dashboard/components/SaveModal.tsx 45.45% <25.00%> (-1.72%) ⬇️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 54.62% <69.23%> (ø)
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/cli.py 33.66% <0.00%> (-17.33%) ⬇️
superset/models/dashboard.py 75.00% <0.00%> (-2.42%) ⬇️
superset/views/database/views.py 87.56% <0.00%> (-1.91%) ⬇️
...tend/src/SqlLab/components/ScheduleQueryButton.tsx 28.12% <0.00%> (-1.11%) ⬇️
...t-frontend/src/dashboard/reducers/nativeFilters.ts 88.23% <0.00%> (-0.96%) ⬇️
...et-frontend/src/dashboard/actions/nativeFilters.ts 80.00% <0.00%> (-0.96%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff35df...0ce5f5b. Read the comment docs.

@pkdotson
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://34.215.31.89:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

pkdotson
pkdotson approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the row and col comments it looks good to go!

rusackas
rusackas reviewed Apr 23, 2021
View reviewed changes
superset-frontend/src/explore/components/controls/VizTypeControl.jsx
@@ -119,7 +120,7 @@ const VizTypeControl = props => {

useEffect(() => {
if (showModal) {
searchRef?.current?.focus();
setTimeout(() => searchRef?.current?.focus(), 200);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about the need for the timeout, and if the 200 is based on anything (e.g. some transition timing) or if it's just a guess at some loading/drawing/mounting time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUT... this fixes the auto-focusing of the input when the modal opens, and I LOVE it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vazco/uniforms#279
The 200 is a common value found in other places of the application for rendering purposes.

rusackas
rusackas approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about one line, but in practice that line fixes something that's been bothering me. So I double-love this PR.

@rusackas
Copy link
Member

Just needs a rebase, and I'll merge this sucker!

@pkdotson pkdotson merged commit 4fbb572 into apache:master Apr 26, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@michael-s-molina
refactor: Bootstrap to AntD - Form - iteration 1 (apache#14106)
2cfd64a
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkdotson pkdotson pkdotson approved these changes

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-s-molina @pkdotson @rusackas @mistercrunch