Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Bootstrap to AntD - ListGroup #13996

Merged
merged 2 commits into from
Apr 13, 2021
Merged

refactor: Bootstrap to AntD - ListGroup #13996

merged 2 commits into from
Apr 13, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Migrates the ListGroup component from Bootstrap to AntD
  • Standardizes the time series control add button and list items height
  • Standardizes the annotation and layers items height
  • Adds support to the css prop in tests

See: #10254

@rusackas @junlincc @pkdotson

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-04-07 at 9 40 51 AM

Screen Shot 2021-04-07 at 10 57 37 AM

Screen Shot 2021-04-07 at 11 18 49 AM

Screen Shot 2021-04-07 at 2 53 24 PM

TEST PLAN

1 - Open a chart in Explore that has the Annotation and Layers control
2 - Check component
3 - Open a chart in Explore that has the Time Series Columns control
4 - Check component

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 7, 2021 •
edited
Loading

Codecov Report

Merging #13996 (a09ab8d) into master (9c5264a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a09ab8d differs from pull request most recent head 94892e8. Consider uploading reports for the commit 94892e8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13996      +/-   ##
==========================================
+ Coverage   79.70%   79.72%   +0.01%     
==========================================
  Files         942      943       +1     
  Lines       47683    47707      +24     
  Branches     6010     6027      +17     
==========================================
+ Hits        38008    38033      +25     
+ Misses       9554     9553       -1     
  Partials      121      121
Flag Coverage Δ
cypress 56.35% <90.90%> (+<0.01%) ⬆️
javascript 69.72% <88.88%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/dashboard/components/PropertiesModal/index.jsx 85.61% <ø> (ø)
superset/views/dashboard/mixin.py 95.00% <ø> (ø)
...rontend/src/SqlLab/components/ShareSqlLabQuery.tsx 88.37% <100.00%> (-0.99%) ⬇️
superset-frontend/src/common/components/index.tsx 100.00% <100.00%> (ø)
...mponents/controls/AnnotationLayerControl/index.jsx 83.33% <100.00%> (+0.47%) ⬆️
...re/components/controls/CollectionControl/index.jsx 86.11% <100.00%> (+1.26%) ⬆️
...plore/components/controls/CustomListItem/index.tsx 100.00% <100.00%> (ø)
superset/connectors/sqla/models.py 88.48% <100.00%> (ø)
superset/security/manager.py 91.14% <100.00%> (ø)
superset-frontend/src/filters/utils.ts 95.23% <0.00%> (-4.77%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c5264a...94892e8. Read the comment docs.

@michael-s-molina michael-s-molina force-pushed the bootstrap-to-antd-listgroup branch 3 times, most recently from 19ec006 to c95d303 Compare April 8, 2021 12:47
@junlincc junlincc added the frontend:refactor Related to refactoring the frontend label Apr 8, 2021
@suddjian
Copy link
Member

suddjian commented Apr 8, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2021

@suddjian Ephemeral environment creation is currently limited to committers.

@junlincc
Copy link
Member

junlincc commented Apr 9, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2021

@junlincc Ephemeral environment spinning up at http://35.163.211.227:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

junlincc
junlincc reviewed Apr 9, 2021
View reviewed changes
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

pkdotson
pkdotson approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rusackas
rusackas reviewed Apr 13, 2021
View reviewed changes
superset-frontend/spec/javascripts/dashboard/components/Header_spec.jsx Outdated
@@ -83,7 +84,11 @@ describe('Header', () => {
};

function setup(overrideProps) {
const wrapper = shallow(<Header {...props} {...overrideProps} />);
const wrapper = mount(
<ThemeProvider theme={supersetTheme}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can skip this, and the superset-ui imports, by using the helper util:
import { styledMount as mount } from 'spec/helpers/theming';
or
import { styledShallow as shallow } from 'spec/helpers/theming';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 😉

rusackas
rusackas approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit c8a7943 into apache:master Apr 13, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@michael-s-molina
refactor: Bootstrap to AntD - ListGroup (apache#13996)
cf5e78a 
* refactor: Bootstrap to AntD - ListGroup

* Improves theme handling on touched files
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junlincc junlincc junlincc left review comments

@pkdotson pkdotson pkdotson approved these changes

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels frontend:refactor Related to refactoring the frontend size/L 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michael-s-molina @suddjian @junlincc @rusackas @pkdotson @mistercrunch