fix: Use superset generic db to catch external_metadata queries #13974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13974 +/- ##
==========================================
- Coverage 79.50% 79.39% -0.12%
==========================================
Files 938 940 +2
Lines 47517 47593 +76
Branches 5939 5962 +23
==========================================
+ Hits 37778 37786 +8
- Misses 9618 9685 +67
- Partials 121 122 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…/databaseerror-databaseerror-redacted-message
hughhhh
changed the title
nytai
approved these changes
Apr 8, 2021
hughhhh
force-pushed
the
hxgh/databaseerror-databaseerror-redacted-message
branch
from
e0e92ed to
e577365
Compare
hughhhh
force-pushed
the
hxgh/databaseerror-databaseerror-redacted-message
branch
from
b089d6a to
300769d
Compare
amitmiran137
pushed a commit
that referenced
this pull request
Apr 13, 2021
* master: (53 commits) test: Adds tests to the UndoRedoKeyListeners component (#13919) chore: Adds dataMask reducer to reducerIndex (#13951) test: Tests audit for the Dashboard FilterBar (#13916) fix: unable to apply logging format (#14074) refactor: Bootstrap to AntD - Slider (#13989) chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata (#13306) fix(listview): update listview feature flag (#13906) Add docs for configuring Docker Compose setup (#13961) feat: invalid password error message (Postgres) (#14038) fix: flacky test in test_update_dataset_item_w_override_columns (#14082) feat: Implement Celery SoftTimeLimit handling (#13740) feat: only send alert error emails to owners of the alert (#13862) feat: add descriptions to report emails (#13827) Make chart exclude itself from cross filtering (#14046) fix: fix bug when remove chart not removing it's related cross filter data (#14081) feat(native-filters): Add default first value to select filter (#13726) feat: Make async query JWT cookie domain configurable (#14007) fix: add exception to catch session not having JWT (#14036) Use consistent chart value (#14031) fix: Use superset generic db to catch external_metadata queries (#13974) ...
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
rusackas
deleted the
hxgh/databaseerror-databaseerror-redacted-message
branch
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Stopping 500 errors from raising on external metadata queries. So wrapped
cursor = conn.cursor()inside try/catch with aSupersetGenericDBErrorto return 400 instead.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION