Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Revert "refactor: ScheduleQueryButton into functional component (#134… #13785

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Mar 24, 2021

…43)"

This reverts commit 2c3d9e9.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogo

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #13785 (ee106f2) into master (2c3d9e9) will decrease coverage by 0.02%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13785      +/-   ##
==========================================
- Coverage   77.48%   77.46%   -0.03%     
==========================================
  Files         933      933              
  Lines       47192    47188       -4     
  Branches     5867     5861       -6     
==========================================
- Hits        36569    36555      -14     
- Misses      10481    10491      +10     
  Partials      142      142              
Flag Coverage Δ
cypress 56.24% <10.00%> (-0.04%) ⬇️
hive 80.25% <ø> (ø)
javascript 63.53% <10.00%> (-0.05%) ⬇️
mysql 80.56% <ø> (ø)
postgres 80.59% <ø> (ø)
presto 80.25% <ø> (-0.01%) ⬇️
python 81.10% <ø> (-0.01%) ⬇️
sqlite 80.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/components/FormLabel/index.tsx 100.00% <ø> (ø)
...tend/src/SqlLab/components/ScheduleQueryButton.jsx 10.00% <10.00%> (ø)
superset/db_engine_specs/presto.py 88.28% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3d9e9...ee106f2. Read the comment docs.

@hughhhh hughhhh changed the title Revert "refactor: ScheduleQueryButton into functional component (#134… refactor: Revert "refactor: ScheduleQueryButton into functional component (#134… Mar 25, 2021
@hughhhh hughhhh merged commit 71ca5ac into master Mar 25, 2021
@hughhhh hughhhh deleted the revert-2c3d9e9b1ede7c9b8eb5e5c66759c8b959287397 branch March 25, 2021 02:51
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants