Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: DatasourceControl #13605

Merged
merged 10 commits into from
Apr 1, 2021
Merged

test: DatasourceControl #13605

merged 10 commits into from
Apr 1, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Mar 12, 2021

SUMMARY

Tests for DatasourceControl

  • Moved to own folder
  • Creating tests for the component

TEST PLAN

No behavior changes and the interface for importing was maintained.
All tests must pass.

@codecov
Copy link

codecov bot commented Mar 12, 2021 •
edited
Loading

Codecov Report

Merging #13605 (823f9b9) into master (a45a5e1) will increase coverage by 0.03%.
The diff coverage is 76.04%.

❗ Current head 823f9b9 differs from pull request most recent head 31433ed. Consider uploading reports for the commit 31433ed to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13605      +/-   ##
==========================================
+ Coverage   77.54%   77.58%   +0.03%     
==========================================
  Files         934      935       +1     
  Lines       47249    47292      +43     
  Branches     5892     5896       +4     
==========================================
+ Hits        36641    36690      +49     
+ Misses      10464    10458       -6     
  Partials      144      144
Flag Coverage Δ
cypress 56.03% <59.25%> (-0.02%) ⬇️
javascript 63.78% <44.77%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Loading/index.tsx 100.00% <ø> (ø)
...re/components/controls/DatasourceControl/index.jsx 86.84% <ø> (ø)
...ters/FiltersConfigModal/FiltersConfigForm/state.ts 76.00% <50.00%> (-12.89%) ⬇️
superset/viz.py 56.07% <50.00%> (ø)
...veFilters/FilterBar/FilterControls/FilterValue.tsx 74.24% <54.16%> (-11.22%) ⬇️
...erset-frontend/src/SqlLab/components/ResultSet.tsx 69.56% <66.66%> (+0.92%) ⬆️
superset/views/core.py 75.66% <75.00%> (+0.03%) ⬆️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 93.10% <85.71%> (-0.65%) ⬇️
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 100.00% <100.00%> (+9.52%) ⬆️
superset-frontend/src/explore/store.js 92.85% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45a5e1...31433ed. Read the comment docs.

michael-s-molina
michael-s-molina reviewed Mar 18, 2021
View reviewed changes
superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx Outdated Show resolved Hide resolved
superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx Outdated Show resolved Hide resolved
superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx Outdated Show resolved Hide resolved
superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx Outdated Show resolved Hide resolved
superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx Show resolved Hide resolved
superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx Show resolved Hide resolved
superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx Show resolved Hide resolved
yardz and others added 3 commits March 18, 2021 12:19
@yardz @michael-s-molina
Update superset-frontend/src/explore/components/controls/DatasourceCo…
a69b3e6 
…ntrol/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/explore/components/controls/DatasourceCo…
d9a4e6d 
…ntrol/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/explore/components/controls/DatasourceCo…
4cba16f 
…ntrol/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz yardz closed this Mar 23, 2021
@yardz yardz reopened this Mar 23, 2021
geido
geido approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rusackas
rusackas approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@rusackas rusackas merged commit ec5d2f5 into apache:master Apr 1, 2021
amitmiran137 pushed a commit that referenced this pull request Apr 2, 2021
Merge branch 'master' into feat/dashboard_extra_jwt
308c659 
* master: (26 commits)
  chore: bump to new superset-ui version (#13932)
  fix: do not run containers as root by default in Helm chart (#13917)
  feat(explore): adhoc column formatting for Table chart (#13758)
  fix(sqla-query): order by aggregations in Presto and Hive (#13739)
  feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894)
  test: Fixes PropertiesModal_spec (#13548)
  fix: Pin Prophet dependency after breaking changes (#13852)
  test: Adds tests to dnd controls (#13650)
  test: Adds tests to the AnnotationLayer component (#13748)
  test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799)
  Add tests (#13778)
  test: DisplayQueryButton (#13750)
  Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905)
  Revert "fix: select table overlay (#13694)" (#13901)
  test: Adds tests to the OptionControls component (#13729)
  test: DatasourceControl (#13605)
  tests for function handleScroll (#13896)
  test: Adds tests to the CustomFrame component (#13675)
  test: Adds tests to the AdvancedFrame component (#13664)
  test: DataTableControl (#13668)
  ...
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
@yardz @michael-s-molina @lyndsiWilliams
test: DatasourceControl (apache#13605)
529ad33 
* Tests for DatasourceControl

* fix: lint error

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Remove error comment

* replace component data-test

* factory to props

Co-authored-by: Michael S. Molina <[email protected]>
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@yardz @michael-s-molina
test: DatasourceControl (apache#13605)
8988959 
* Tests for DatasourceControl

* fix: lint error

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Remove error comment

* replace component data-test

* factory to props

Co-authored-by: Michael S. Molina <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@geido geido geido approved these changes

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L test:component 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yardz @rusackas @geido @michael-s-molina @mistercrunch @junlincc