Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add node/npm versions to contributing.md #1344

Merged
merged 3 commits into from
Oct 14, 2016
Merged

add node/npm versions to contributing.md #1344

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f5d655
add node and npm versions
Oct 14, 2016
421b4db
use lower case npm
Oct 14, 2016
657de0a
update wording
Oct 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ Flask-Appbuilder itself comes bundled with jQuery and bootstrap.
While these may be phased out over time, these packages are currently not
managed with npm.

### Node/npm versions
Make sure you are using Node v6.2.2 and npm v3.9.5.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just check out of curiosity what I'm using and I have node v5.10.1 and npm 3.10.5 . Maybe the note needs to sound a less strict. "Make sure you are using recent versions of node and npm. No problem have been seen with node>=5.10 and npm>=3.9"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea +1


### Using npm to generate bundled files

Expand Down