Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polyfill es2015 in older browsers and for phantomjs #1323

Merged
merged 2 commits into from
Oct 12, 2016
Merged

polyfill es2015 in older browsers and for phantomjs #1323

merged 2 commits into from
Oct 12, 2016

Conversation

ascott
Copy link
Contributor

@ascott ascott commented Oct 12, 2016

only need to include babel-polyfill once per js entry file. since css-theme and common.js are both used with the dashboard, sqllab, etc, they don't need the polyfill since it's already been included in the single page app entry file.

IE11 before:
screenshot 2016-10-11 20 02 05

IE 11 after:
screenshot 2016-10-11 19 59 30

@williaster @mistercrunch @bkyryliuk

@ascott ascott mentioned this pull request Oct 12, 2016
@williaster
Copy link
Contributor

nice! also the browserstack.com tool you're using looks useful!

@gschrader
Copy link
Contributor

gschrader commented Oct 12, 2016

I just tested this on IE 11 and there still seems to be a problem:

image

the wrong url seems to be generated to grab the json, IE url vs Chrome url . Looks like it's missing caravel/explore/table/3 as a prefix.

This is maybe what was being reported in #1201 and I'm not sure why works fine in browserstack.com.

Regardless this change works for my other browser and can still hopefully be merged. Thanks!

@ascott
Copy link
Contributor Author

ascott commented Oct 12, 2016

@gschrader that is a different bug/issue with IE not forming the correct URL for the slice, and not related to this polyfill change. would be great if you could create a new issue documenting this bug. thanks!

@ascott ascott merged commit 5cb3cc2 into apache:master Oct 12, 2016
@gschrader
Copy link
Contributor

@ascott agreed it's a different issue, I will raise a new issue (probably won't get a chance until tomorrow).

@gschrader gschrader mentioned this pull request Oct 13, 2016
@panutat
Copy link

panutat commented Mar 4, 2017

Did you have to do anything special to get PhantomJS to wait and detect elements rendered in slice_container? For some reason I can't select any SVG elements no matter how long I wait after page load.

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants