-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polyfill es2015 in older browsers and for phantomjs #1323
Conversation
nice! also the |
I just tested this on IE 11 and there still seems to be a problem: the wrong url seems to be generated to grab the json, IE url vs Chrome url . Looks like it's missing This is maybe what was being reported in #1201 and I'm not sure why works fine in Regardless this change works for my other browser and can still hopefully be merged. Thanks! |
@gschrader that is a different bug/issue with IE not forming the correct URL for the slice, and not related to this polyfill change. would be great if you could create a new issue documenting this bug. thanks! |
@ascott agreed it's a different issue, I will raise a new issue (probably won't get a chance until tomorrow). |
Did you have to do anything special to get PhantomJS to wait and detect elements rendered in slice_container? For some reason I can't select any SVG elements no matter how long I wait after page load. |
only need to include
babel-polyfill
once per js entry file. since css-theme and common.js are both used with the dashboard, sqllab, etc, they don't need the polyfill since it's already been included in the single page app entry file.IE11 before:
IE 11 after:
@williaster @mistercrunch @bkyryliuk