-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Config for dataset health check #12906
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -704,7 +704,13 @@ def data(self) -> Dict[str, Any]: | |
data_["fetch_values_predicate"] = self.fetch_values_predicate | ||
data_["template_params"] = self.template_params | ||
data_["is_sqllab_view"] = self.is_sqllab_view | ||
data_["health_check_message"] = self.health_check_message | ||
# Don't return previously populated health check message in case | ||
# the health check feature is turned off | ||
data_["health_check_message"] = ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should not return health check message, when feature is disabled but had populated health check message before. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add this comment to code as well?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed. |
||
self.health_check_message | ||
if config.get("DATASET_HEALTH_CHECK") | ||
else None | ||
) | ||
return data_ | ||
|
||
@property | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config listed below the overwrite function won't be overwritten. Have to move it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment block here to stop others from adding new config below this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for that warning, we've seen issues with config values being added after overrides are loaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!