Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump superset-ui packages to v0.17.2 and v0.17.3 #12854

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Feb 1, 2021

SUMMARY

Brings in apache-superset/superset-ui#914 which replaces react-bootstrap tooltips with AntD, and apache-superset/superset-ui#925 which fixes 12853 .

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See related issues

TEST PLAN

Verify:

  1. Table chart does not produce normalized values for raw records
  2. Tooltips in chart controls should still work

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Feb 1, 2021

Codecov Report

Merging #12854 (4eaa43f) into master (9a7fba8) will decrease coverage by 3.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12854      +/-   ##
==========================================
- Coverage   67.04%   63.38%   -3.66%     
==========================================
  Files        1022      489     -533     
  Lines       50186    30195   -19991     
  Branches     5204        0    -5204     
==========================================
- Hits        33647    19140   -14507     
+ Misses      16404    11055    -5349     
+ Partials      135        0     -135     
Flag Coverage Δ
cypress ?
javascript ?
python 63.38% <ø> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/database/views.py 62.69% <0.00%> (-24.88%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/sql_validators/base.py 93.33% <0.00%> (-6.67%) ⬇️
superset/db_engine_specs/base.py 79.59% <0.00%> (-6.38%) ⬇️
superset/db_engine_specs/presto.py 82.25% <0.00%> (-6.28%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/views/database/forms.py 83.33% <0.00%> (-5.56%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
... and 544 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7fba8...4eaa43f. Read the comment docs.

@villebro
Copy link
Member

villebro commented Feb 1, 2021

@ktmud it seems nvd3 is still on the old 0.16 version - can you bump that, too?

@villebro villebro merged commit 783aae1 into apache:master Feb 1, 2021
@ktmud ktmud deleted the bump-superset-ui branch February 1, 2021 18:40
villebro pushed a commit to preset-io/superset that referenced this pull request Feb 2, 2021
* chore: bump superset-ui packages to v0.17.2 and v0.17.3

* Bump also the nvd3 chart
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants