Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reports): handle exceptions properly in scope #12811

Merged
merged 4 commits into from
Jan 28, 2021

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jan 28, 2021

SUMMARY

Fixes badly handled exception flow on reports and worker session_scope. This would surface any exceptions raised inside the exception block even if they were handled after

Also includes a fix that surfaces on SQLite but is not correct, since by default celery JSON serialises the datetime type is not preserved

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar marked this pull request as ready for review January 28, 2021 14:23
@codecov-io
Copy link

codecov-io commented Jan 28, 2021

Codecov Report

Merging #12811 (8db9de0) into master (32f2c45) will decrease coverage by 3.22%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12811      +/-   ##
==========================================
- Coverage   67.01%   63.78%   -3.23%     
==========================================
  Files        1022      488     -534     
  Lines       50102    30145   -19957     
  Branches     5191        0    -5191     
==========================================
- Hits        33574    19227   -14347     
+ Misses      16397    10918    -5479     
+ Partials      131        0     -131     
Flag Coverage Δ
cypress ?
javascript ?
python 63.78% <50.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/tasks/scheduler.py 0.00% <0.00%> (ø)
superset/utils/celery.py 86.20% <100.00%> (-13.80%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/models/core.py 85.86% <0.00%> (-2.99%) ⬇️
superset/views/core.py 72.97% <0.00%> (-2.45%) ⬇️
... and 544 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f2c45...8db9de0. Read the comment docs.

@dpgaspar dpgaspar requested review from bkyryliuk, craig-rueda and willbarrett and removed request for craig-rueda January 28, 2021 17:58
@dpgaspar dpgaspar merged commit a0e05a5 into apache:master Jan 28, 2021
@dpgaspar dpgaspar deleted the fix/reports-v3 branch January 28, 2021 19:06
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants