fix: ignore system files on import #12526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12526 +/- ##
==========================================
- Coverage 66.71% 63.16% -3.56%
==========================================
Files 1014 485 -529
Lines 49576 29949 -19627
Branches 4960 0 -4960
==========================================
- Hits 33076 18917 -14159
+ Misses 16377 11032 -5345
+ Partials 123 0 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
reviewed
Jan 15, 2021
| @@ -87,3 +88,11 @@ def is_valid_config(file_name: str) -> bool: | |||
| return False | |||
|
|
|||
| return True | |||
|
|
|||
|
|
|||
| def get_contents_from_bundle(bundle: ZipFile) -> Dict[str, str]: | |||
There was a problem hiding this comment.
write small unit test to cover this
There was a problem hiding this comment.
This is covered in the API tests
dpgaspar
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 20, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#12425 fixed importing ZIP files that contained system files (from unzipping and zipping again on Mac OS), but only for charts. This PR fixes it for all imports.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Unit tests for imports pass.
ADDITIONAL INFORMATION