Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reports): security perm simplification #11853

Merged
merged 7 commits into from
Dec 15, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Nov 30, 2020

SUMMARY

security permission simplification. Scope Reports for API and MVC FAB classes.

Existing permissions:

Permission View
can_add ReportSchedule
can_delete ReportSchedule
can_edit ReportSchedule
can_list ReportSchedule
can_show ReportSchedule

Future permissions:

Permission View
can_read ReportSchedule
can_write ReportSchedule

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 30, 2020
@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #11853 (3c664ec) into master (1afe915) will decrease coverage by 3.93%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11853      +/-   ##
==========================================
- Coverage   67.71%   63.77%   -3.94%     
==========================================
  Files         952      953       +1     
  Lines       46686    46703      +17     
  Branches     4577     4577              
==========================================
- Hits        31615    29787    -1828     
- Misses      14958    16731    +1773     
- Partials      113      185      +72     
Flag Coverage Δ
cypress ?
javascript 62.58% <100.00%> (-0.07%) ⬇️
python 64.50% <6.25%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...versions/40f16acf1ba7_security_converge_reports.py 0.00% <0.00%> (ø)
...perset-frontend/src/views/CRUD/alert/AlertList.tsx 62.65% <100.00%> (-13.26%) ⬇️
superset/reports/api.py 84.34% <100.00%> (+0.13%) ⬆️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1afe915...3c664ec. Read the comment docs.

@dpgaspar dpgaspar changed the title feat: security converge report feat(reports): security perm simplification Dec 2, 2020
@dpgaspar dpgaspar added the risk:db-migration PRs that require a DB migration label Dec 4, 2020
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 14, 2020
@dpgaspar dpgaspar marked this pull request as ready for review December 14, 2020 11:26
@dpgaspar dpgaspar merged commit 0f979de into apache:master Dec 15, 2020
@dpgaspar dpgaspar deleted the feat/security-converge-reports branch December 15, 2020 08:48
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:db-migration PRs that require a DB migration size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants