Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fixing tall filter indicators #11631

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Nov 9, 2020

Co-Authored-By: Evan Rusackas [email protected]

SUMMARY

Fixes #11626

When we un-truncated chart headers again, this issue crept in. As you can see by the screenshots, it now looks as intended.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2020-11-09 at 3 44 22 PM

After:
Screen Shot 2020-11-09 at 3 46 03 PM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #11631 (6bf3946) into master (5be1dbe) will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11631      +/-   ##
==========================================
- Coverage   61.92%   61.28%   -0.64%     
==========================================
  Files         422      422              
  Lines       26295    26284      -11     
==========================================
- Hits        16282    16109     -173     
- Misses      10013    10175     +162     
Flag Coverage Δ
python 61.28% <ø> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 53.90% <0.00%> (-30.08%) ⬇️
superset/db_engine_specs/presto.py 69.76% <0.00%> (-12.53%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/db_engine_specs/postgres.py 97.56% <0.00%> (-2.44%) ⬇️
superset/examples/birth_names.py 96.51% <0.00%> (-2.33%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 88.42% <0.00%> (-0.83%) ⬇️
superset/views/base_api.py 97.53% <0.00%> (-0.50%) ⬇️
superset/connectors/sqla/models.py 90.48% <0.00%> (-0.15%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be1dbe...6bf3946. Read the comment docs.

@rusackas rusackas merged commit d315dd9 into apache:master Nov 10, 2020
@rusackas rusackas deleted the tall-filter-indicators branch November 10, 2020 00:17
graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this pull request Nov 10, 2020
Co-Authored-By: Evan Rusackas <[email protected]>
(cherry picked from commit d315dd9)
@junlincc junlincc added the rush! Requires immediate attention label Nov 10, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@junlincc junlincc removed the rush! Requires immediate attention label Mar 18, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants