Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add support for Google Analytics on superset.apache.org #11613

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Nov 7, 2020

SUMMARY

The intent is to add all committers / PMC as admin on the Google Analytics console, and to publish periodic reports to the community.

It's important for the community to monitor it's health and traffic on superset.apache.org is a good proxy for this, and important data points that can inform decisions to help grow the community.

I know the Apache Airflow community uses Google Analytics in a similar fashion, so I figure it's reasonable to do this.

@codecov-io
Copy link

codecov-io commented Nov 7, 2020

Codecov Report

Merging #11613 (c166d57) into master (d861173) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11613   +/-   ##
=======================================
  Coverage   62.26%   62.26%           
=======================================
  Files         873      873           
  Lines       42256    42256           
  Branches     3961     3961           
=======================================
  Hits        26310    26310           
  Misses      15766    15766           
  Partials      180      180           
Flag Coverage Δ
javascript 62.83% <ø> (ø)
python 61.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d861173...c166d57. Read the comment docs.

@mistercrunch
Copy link
Member Author

Also had to npm upgrade since gatsby was sending me in another round of dependency hell

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming Google Analytics is kosher as far as apache is concerned.

Can you also create some issues for reenabling the disabled tests? They could be good first issues too

@mistercrunch mistercrunch merged commit 5cb6c25 into master Nov 12, 2020
@mistercrunch mistercrunch deleted the ga branch November 12, 2020 21:59
robdiciuccio added a commit to preset-io/superset that referenced this pull request Nov 13, 2020
mistercrunch pushed a commit that referenced this pull request Nov 15, 2020
…ing locally (#11698)

* Update @cypress/code-coverage to latest

* Set nyc reporter to html/text

* Revert dashboard list test changes from #11613

* Update codecov reporting to summary format

* Add json reporter for codecov.io

* Silence inline coverage reports
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
…#11613)

* docs: add support for Google Analytics

* fix failing cypress test in list_view.test.ts

* xit some tests
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
…ing locally (apache#11698)

* Update @cypress/code-coverage to latest

* Set nyc reporter to html/text

* Revert dashboard list test changes from apache#11613

* Update codecov reporting to summary format

* Add json reporter for codecov.io

* Silence inline coverage reports
@villebro villebro mentioned this pull request Feb 23, 2022
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants