Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace react-bootstrap MenuItems with Antd Menu #11554

Merged
merged 6 commits into from
Nov 5, 2020
Merged

refactor: Replace react-bootstrap MenuItems with Antd Menu #11554

merged 6 commits into from
Nov 5, 2020

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Nov 4, 2020 •
edited
Loading

SUMMARY

Replaces MenuItems in SliceHeaderControls, DisplayQueryButton and SliceAdder components.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje
Copy link
Member Author

kgabryje commented Nov 4, 2020

@rusackas @junlincc Can you take a look?

rusackas
rusackas reviewed Nov 4, 2020
View reviewed changes
superset-frontend/src/components/Menu/LanguagePicker.tsx Outdated
langKey === locale ? null : (
<Menu.Item key={langKey}>
{' '}
<div className="f16">
Copy link
Member

@rusackas rusackas Nov 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what this f16 class does (or the div, for that matter)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.f16 .flag-code and .f16 .flag provide styles for the flag icons

@kgabryje
Copy link
Member Author

kgabryje commented Nov 5, 2020

@rusackas This PR was bigger than it was supposed to be because I forgot to do the rebase and there were some changes that were already merged - I apologise for that. On the bright side, you caught some css in style thanks to that 😛

@codecov-io
Copy link

codecov-io commented Nov 5, 2020 •
edited
Loading

Codecov Report

Merging #11554 into master will increase coverage by 2.67%.
The diff coverage is 28.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11554      +/-   ##
==========================================
+ Coverage   59.59%   62.27%   +2.67%     
==========================================
  Files         832      876      +44     
  Lines       40482    42172    +1690     
  Branches     3666     3954     +288     
==========================================
+ Hits        24126    26262    +2136     
+ Misses      16187    15728     -459     
- Partials      169      182      +13
Flag Coverage Δ
cypress ?
javascript 62.46% <28.00%> (?)
python 62.15% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Menu/Menu.tsx 61.42% <ø> (-30.24%) ⬇️
superset-frontend/src/components/ModalTrigger.jsx 91.30% <ø> (-0.70%) ⬇️
...rset-frontend/src/components/URLShortLinkModal.jsx 80.00% <ø> (ø)
...d/src/dashboard/components/SliceHeaderControls.jsx 11.29% <6.45%> (-64.27%) ⬇️
...tend/src/explore/components/DisplayQueryButton.jsx 42.52% <25.00%> (-25.48%) ⬇️
.../explore/components/controls/DateFilterControl.jsx 55.49% <58.82%> (-4.99%) ⬇️
...t-frontend/src/dashboard/components/SliceAdder.jsx 82.08% <100.00%> (-4.48%) ⬇️
superset-frontend/src/views/App.tsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/views/menu.tsx 0.00% <0.00%> (-100.00%) ⬇️
... and 368 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52145f8...df42b9a. Read the comment docs.

rusackas
rusackas approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

LGTM

@rusackas rusackas merged commit 1490f30 into apache:master Nov 5, 2020
@ktmud
Copy link
Member

ktmud commented Nov 10, 2020

Previously the menu will automatically close whichever item you click, now it doesn't close.

menu-not-close

@rusackas @kgabryje

@ktmud ktmud mentioned this pull request Nov 10, 2020
Closed
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@kgabryje @auxten
refactor: Replace react-bootstrap MenuItems with Antd Menu (apache#11554
0354c00 
)

* Refactor SliceHeaderControls

* Refactor DisplayQueryButton

* Fix duplicate keys

* Refactor SliceAdder

* Move css from styles to Emotion

* Fix e2e test
@graceguo-supercat graceguo-supercat mentioned this pull request Sep 8, 2021
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kgabryje @codecov-io @ktmud @rusackas @mistercrunch